buy_report Get details & Put status APIの作成 #920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hikahana
changed the base branch from
develop
to
feat/yama/913/create-mypage-front
Kubosaka
reviewed
Feb 14, 2025
| return nil, err | ||
| } | ||
|
|
||
| getDs := selectBuyReportDetailsQuery.Where(goqu.Ex{"buy_statuses.buy_report_id": buyReportId}) |
Collaborator
There was a problem hiding this comment.
[imo]
これrepository内のメソッドとして定義して、usecaseから使って欲しいかも
1つの処置につき、1つのメソッドの方が綺麗な気がする
これに関しては意見欲しいかも
Collaborator
Author
There was a problem hiding this comment.
1つの処置につき、1つのメソッドの方が綺麗な気がする
これ非常に同感です。
作成されたdetailを返すまでがupdateかなと思って一つにしてました。
けどrepository内で処理を完結させる必要もないですし、いい感じに分けました。
Comment on lines
300
to
302
| if err != nil { | ||
| return detail, errors.Wrapf(err, "cannot connect SQL") | ||
| } |
Collaborator
There was a problem hiding this comment.
[ask]
これのエラーはcannot connect SQLじゃないよね？
取得したrowをdetailに渡すときのエラーだよね
Collaborator
Author
There was a problem hiding this comment.
そうですね。どっかのコピペして大本作ってたので修正抜けです。
Kubosaka
reviewed
Feb 17, 2025
| return BuyReportDetail{}, err | ||
| } | ||
|
|
||
| row, err := bru.bRep.AllByPeriod(c, buyReportId) |
Collaborator
There was a problem hiding this comment.
このmethod使ったらダメな気がします！
idからBuyReportDetailで取得するAPIはない気がするので、新しく実装する必要有りかも
// 年度に紐づいたdetailsの取得
func (brr *buyReportRepository) AllByPeriod(c context.Context, year string) (*sql.Rows, error) {
Collaborator
Author
There was a problem hiding this comment.
確かに、、、
AllByBuyReportIdのメソッド作成しました！
Kubosaka
reviewed
Feb 18, 2025
| return brr.crud.Read(c, query) | ||
| } | ||
|
|
||
| func (brr *buyReportRepository) AllByBuyReportId(c context.Context, buyReportId string) (*sql.Row, error) { |
Collaborator
There was a problem hiding this comment.
細かいですが、ByIDならGet~使って欲しいかもです！
Base automatically changed from
feat/yama/913/create-mypage-front
to
develop
February 24, 2025 06:36
Deploying finansu with
|
| Latest commit: |
01f33e9
|
| Status: | 🚫 Build failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
対応Issue
resolve #0
概要
buy_reportのAPIを作成しました。
画面スクリーンショット等
URLスクリーンショット
テスト項目
備考
予算管理フロント作成から切ってます