Skip to content

Conversation

@Kubosaka
Copy link
Collaborator

@Kubosaka Kubosaka commented Feb 5, 2025

対応Issue

概要

  • routerでルーティングしていたものを、openapiの自動生成で行えるようにした
  • 不要なルーティングの削除

画面スクリーンショット等

  • URL
    スクリーンショット

テスト項目

備考

@Kubosaka Kubosaka marked this pull request as draft February 5, 2025 13:03
@Kubosaka Kubosaka self-assigned this Feb 12, 2025
Copy link
Collaborator

@hikahana hikahana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

タイポだけ見た

func (h *Handler) PostActivities(c echo.Context) error {
activities := new(domain.Activity)
if err := c.Bind(activities); err != nil {
fmt.Println("err")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これいらない。

return err
}

latastActivityStyle, err := h.activityStyleUseCase.CreateActivityStyle(c.Request().Context(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

タイポ
latestActivityStale

return err
}

latastSponsor, err := h.sponsorUseCase.CreateSponsor(c.Request().Context(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

latestSponsor


// router.GET(baseURL+"/sponsorstyles", wrapper.GetSponsorstyles)
func (h *Handler) GetSponsorstyles(c echo.Context) error {
sponsorstyles, err := h.sponsorStyleUseCase.GetSponsorStyles(c.Request().Context())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sponsorStyles

return err
}

latastSponsorstyle, err := h.sponsorStyleUseCase.CreateSponsorStyle(c.Request().Context(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

latestSponsorStyle

name := params.Name
bureauID := strconv.Itoa(params.BureauId)
roleID := strconv.Itoa(params.RoleId)
latastUser, err := h.userUseCase.CreateUser(c.Request().Context(), name, bureauID, roleID)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

latestUser

@Kubosaka Kubosaka marked this pull request as ready for review September 26, 2025 14:44
@Kubosaka Kubosaka changed the base branch from develop to work/2026-finansu-prepare September 26, 2025 14:44
Copy link
Collaborator

@hikahana hikahana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良さ!コメントしてるけどこのPRとは関係ないからapprove!!!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

くそだるだからいつかでやりたいけど。
APIごとにopenapi.yaml分けたいかも。
aiに投げるとき3000行あると精度悪くなりそう。

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

そういえばgoogle wire導入してたからhandlerマージ後にこっちのPRもfinansu-prepareにマージしたいね
#1011

Comment on lines +42 to +44
type (
PutIncomeExpenditureManagementsCheckIdJSONBody = generated.PutIncomeExpenditureManagementsCheckIdJSONBody
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これ使ってないかも?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

29行目で使ってるー

var body generated.PutIncomeExpenditureManagementsCheckIdJSONBody
if err := c.Bind(&body); err != nil {
return err
}

@Kubosaka Kubosaka changed the base branch from work/2026-finansu-prepare to develop November 27, 2025 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants