-
Notifications
You must be signed in to change notification settings - Fork 2
openapiでhandler自動生成 #918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
openapiでhandler自動生成 #918
Conversation
hikahana
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
タイポだけ見た
| func (h *Handler) PostActivities(c echo.Context) error { | ||
| activities := new(domain.Activity) | ||
| if err := c.Bind(activities); err != nil { | ||
| fmt.Println("err") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
これいらない。
| return err | ||
| } | ||
|
|
||
| latastActivityStyle, err := h.activityStyleUseCase.CreateActivityStyle(c.Request().Context(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
タイポ
latestActivityStale
| return err | ||
| } | ||
|
|
||
| latastSponsor, err := h.sponsorUseCase.CreateSponsor(c.Request().Context(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
latestSponsor
|
|
||
| // router.GET(baseURL+"/sponsorstyles", wrapper.GetSponsorstyles) | ||
| func (h *Handler) GetSponsorstyles(c echo.Context) error { | ||
| sponsorstyles, err := h.sponsorStyleUseCase.GetSponsorStyles(c.Request().Context()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sponsorStyles
| return err | ||
| } | ||
|
|
||
| latastSponsorstyle, err := h.sponsorStyleUseCase.CreateSponsorStyle(c.Request().Context(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
latestSponsorStyle
| name := params.Name | ||
| bureauID := strconv.Itoa(params.BureauId) | ||
| roleID := strconv.Itoa(params.RoleId) | ||
| latastUser, err := h.userUseCase.CreateUser(c.Request().Context(), name, bureauID, roleID) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
latestUser
hikahana
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
良さ!コメントしてるけどこのPRとは関係ないからapprove!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
くそだるだからいつかでやりたいけど。
APIごとにopenapi.yaml分けたいかも。
aiに投げるとき3000行あると精度悪くなりそう。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
そういえばgoogle wire導入してたからhandlerマージ後にこっちのPRもfinansu-prepareにマージしたいね
#1011
| type ( | ||
| PutIncomeExpenditureManagementsCheckIdJSONBody = generated.PutIncomeExpenditureManagementsCheckIdJSONBody | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
これ使ってないかも?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
29行目で使ってるー
| var body generated.PutIncomeExpenditureManagementsCheckIdJSONBody | |
| if err := c.Bind(&body); err != nil { | |
| return err | |
| } |
対応Issue
概要
画面スクリーンショット等
URLスクリーンショット
テスト項目
備考