Storybookに既存コンポーネントを表示する(/sponsorstyles) #847
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Button OpenEditModalButton SponsorStyleAddModal
Kubosaka
reviewed
Jul 18, 2024
Collaborator
Kubosaka
left a comment
Kubosaka
left a comment
There was a problem hiding this comment.
ModalPropsはstorybookで使ってなくて、exportしなくていいかと思いましたのでコメントしました
| import { Modal, CloseButton, OutlinePrimaryButton, PrimaryButton } from '@components/common'; | ||
|
|
||
| interface ModalProps { | ||
| export interface ModalProps { |
Collaborator
There was a problem hiding this comment.
Suggested change
| export interface ModalProps { | |
| interface ModalProps { |
ModalPropsは使っていなので、exportしなくていいかと思います！
| import { SponsorStyle } from '@type/common'; | ||
|
|
||
| interface ModalProps { | ||
| export interface ModalProps { |
Collaborator
There was a problem hiding this comment.
Suggested change
| export interface ModalProps { | |
| interface ModalProps { |
ここも！
| import { AddButton } from '@components/common'; | ||
|
|
||
| interface Props { | ||
| export interface Props { |
Collaborator
There was a problem hiding this comment.
Suggested change
| export interface Props { | |
| interface Props { |
ここも！
| import { DeleteButton } from '@components/common'; | ||
|
|
||
| interface Props { | ||
| export interface Props { |
Collaborator
There was a problem hiding this comment.
Suggested change
| export interface Props { | |
| interface Props { |
ここも！
| import { SponsorStyle } from '@type/common'; | ||
|
|
||
| interface Props { | ||
| export interface Props { |
Collaborator
There was a problem hiding this comment.
Suggested change
| export interface Props { | |
| interface Props { |
| import { SponsorStyle } from '@type/common'; | ||
|
|
||
| interface ModalProps { | ||
| export interface ModalProps { |
Collaborator
There was a problem hiding this comment.
Suggested change
| export interface ModalProps { | |
| interface ModalProps { |
Kubosaka
reviewed
Jul 25, 2024
| import { DeleteButton } from '@components/common'; | ||
|
|
||
| interface Props { | ||
| export interface Props { |
| import { SponsorStyle } from '@type/common'; | ||
|
|
||
| interface Props { | ||
| export interface Props { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
対応Issue
resolve #807
概要
以下のファイルを追加
index.ts
DeleteModal.stories.tsx
EditModal.stories.tsx
OpenAddModalButton.stories.tsx
OpenDeleteModalButton.stories.tsx
OpenEditModalButton.stories.tsx
SponsorStyleAddModal.stories.tsx
画面スクリーンショット等
テスト項目
備考