Changes to FmuBuilder.build_FMU. 1. Unload the script module after th… #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e FMU is built to avoid that the cached script is used when using the FMU 2. Optionally allow non-default names for the resulting FMU file 3. Check that the script file is not among the project files 4. Add a documentation text to the function.
Jorgelmh
reviewed
Jul 3, 2025
Jorgelmh
requested changes
Jul 3, 2025
Collaborator
Jorgelmh
left a comment
Jorgelmh
left a comment
There was a problem hiding this comment.
LGTM! Just need to correct a conditional and we're good to merge
Jorgelmh
approved these changes
Jul 3, 2025
davidhjp01
reviewed
Jul 3, 2025
Comment on lines
+338
to
+339
| if newargs is not None: | ||
| sys.modules.pop(Path(script_file).stem) # otherwise old script may be active when loading the FMU! |
There was a problem hiding this comment.
module syntax can be aaa.bbb.ccc. Path.stem seems to only return filename without the final suffix - but I don't recall we ever put the main script file in some nested module, so probably this is okay?
davidhjp01
reviewed
Jul 3, 2025
Comment on lines
+281
to
+282
| assert file_.name != script_file.name, ( # avoid the inclusion of the script in project files | ||
| "It seems that the script file is included a second time in the project_files") |
There was a problem hiding this comment.
Not sure if we want to only check the name of the file for deciding the assertion. The file name be same in different python modules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e FMU is built to avoid that the cached script is used when using the FMU 2. Optionally allow non-default names for the resulting FMU file 3. Check that the script file is not among the project files 4. Add a documentation text to the function.