Skip to content

finished get restaurant menu items task and add some refactors #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mohamed-abdelhafiz-dev wants to merge 2 commits into
base: main
Choose a base branch
from
Open

finished get restaurant menu items task and add some refactors #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3cb9a4a
finished getResturantMenuItems task and add some refactors
mohammed-abdelhafiz Aug 26, 2025
a407156
create filter util function
mohammed-abdelhafiz Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 21 additions & 21 deletions app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
const express = require('express');
const cookieParser = require('cookie-parser');
const express = require("express");
const cookieParser = require("cookie-parser");
const app = express();
const cors = require('cors');
const { connectDB } = require('./config/db.Config');
const userRouter = require('./routes/user.route');
const restaurantRouter = require('./routes/restaurant.route');
const orderRouter = require('./routes/order.route');
const menuRouter = require('./routes/menu.route');
const menuItemRouter = require('./routes/menuItem.route');
const initial = require('./utils/initial');
const cors = require("cors");
const { connectDB } = require("./config/db.Config");
const userRouter = require("./routes/user.route");
const restaurantRouter = require("./routes/restaurant.route");
const orderRouter = require("./routes/order.route");
const menuRouter = require("./routes/menu.route");
const menuItemRouter = require("./routes/menuItem.route");
const initial = require("./utils/initial");

connectDB();

// initail data
//initial.all();
// Seed initial data
// initial.all();

// Middlewares
app.use(cors());
Expand All @@ -22,15 +22,15 @@ app.use(cookieParser());
app.use(express.urlencoded({ extended: true }));

//Routes
app.use('/api/auth', userRouter);
app.use('/api/restaurants', restaurantRouter);
app.use('/api/menus' , menuRouter);
app.use('/api/menuItems' , menuItemRouter);
app.use('/api/restaurants', menuRouter);
app.use('/api/orders' , orderRouter);
app.use("/api/auth", userRouter);
app.use("/api/restaurants", restaurantRouter);
app.use("/api/menus", menuRouter);
app.use("/api/menuItems", menuItemRouter);
app.use("/api/restaurants", menuRouter);
app.use("/api/orders", orderRouter);

app.get('/', (req, res) => {
res.send('Welcome to the Uber Eats Clone API');
app.get("/", (req, res) => {
res.send("Welcome to the Uber Eats Clone API");
});

module.exports = app;
module.exports = app;
267 changes: 150 additions & 117 deletions controllers/menu.controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,133 +1,166 @@
const { get } = require('mongoose');
const Menu = require('../models/menu.model');
const MenuItem = require('../models/menuItem.model');
const Restaurant = require('../models/restaurant.model');
const dataAccessHelper = require('../utils/Helper/dataAccess');
const {checkRestaurantAuthorization} = require('../middlewares/authorization.middleware')
const cloud = require('../utils/cloud');
const { get } = require("mongoose");
const Menu = require("../models/menu.model");
const MenuItem = require("../models/menuItem.model");
const Restaurant = require("../models/restaurant.model");
const dataAccessHelper = require("../utils/Helper/dataAccess");
const {
checkRestaurantAuthorization,
} = require("../middlewares/authorization.middleware");
const cloud = require("../utils/cloud");

exports.getRestaurantMenuItems = async (req, res) => {
try {
if(!req.user) {
return res.status(401).json({ message: 'You Have To login First' });
}
const menuItems = await dataAccessHelper.getMenuItemsByRestaurantId(req.params.restaurantId);
if (!menuItems) {
return res.status(404).json({ message: 'This Menu has no items' });
}
res.status(200).json({
message: 'Menu items found',
menuItems
});
} catch (error) {
res.status(500).json({
message: 'Internal server error',
process: "Menu Retrieval"
});
try {
if (!req.user) {
return res.status(401).json({ message: "You have to login first" });
}

const { restaurantId } = req.params;
const restaurant = await Restaurant.findById(restaurantId);
if (!restaurant) {
return res.status(404).json({ message: "Restaurant not found" });
}
const menu = await Menu.findOne({ restaurantId: restaurantId });

if (!menu) {
return res.status(404).json({ message: "Menu not found" });
}
const menuItems = await dataAccessHelper.getMenuItemsByMenuId(menu._id);

if (!menuItems || menuItems.length === 0) {
return res.status(404).json({ message: "This menu has no items" });
}
}

const formattedItems = menuItems.map((item) => ({
id: item._id,
name: item.name,
description: item.description,
price: {
amount: item.price?.amount,
currency: item.price?.currency,
},
imageUrl: item.image,
label: item.isAvailable ? "Available" : "Not Available",
}));

const response = {
restaurantId: restaurant._id,
menuId: menu._id,
menuName: menu.name,
items: formattedItems,
};

res.status(200).json(response);
} catch (error) {
res.status(500).json({
message: "Internal server error",
process: "Menu Retrieval",
});
}
};

// restaurant make new menu
exports.createMenu = async (req, res) => {
try {
if (!req.user) {
return res.status(401).json({ message: 'You Have To login First' });
}

const { name, description } = req.body;

const restaurant = await Restaurant.findById(req.params.restaurantId);
if (!restaurant) {
return res.status(404).json({ message: 'Restaurant not found' });
}

const existingMenu = await dataAccessHelper.getMenuByRestaurantId(req.params.restaurantId);
if (existingMenu) {
return res.status(400).json({ message: "This restaurant already have a menu" });
}
const menu = new Menu({
restaurantId: req.user._id,
name,
description,
image: req.menuImage || null, // store the Cloudinary link
});

await menu.save();

return res.status(201).json({
message: 'Menu created successfully',
menu
});

} catch (error) {
console.error("Menu Creation Error:", error);
return res.status(500).json({
message: 'Internal server error',
process: "Menu Creation"
});
try {
if (!req.user) {
return res.status(401).json({ message: "You Have To login First" });
}

const { name, description } = req.body;

const restaurant = await Restaurant.findById(req.params.restaurantId);
if (!restaurant) {
return res.status(404).json({ message: "Restaurant not found" });
}

const existingMenu = await dataAccessHelper.getMenuByRestaurantId(
req.params.restaurantId
);
if (existingMenu) {
return res
.status(400)
.json({ message: "This restaurant already have a menu" });
}
const menu = new Menu({
restaurantId: req.user._id,
name,
description,
image: req.menuImage || null, // store the Cloudinary link
});

await menu.save();

return res.status(201).json({
message: "Menu created successfully",
menu,
});
} catch (error) {
console.error("Menu Creation Error:", error);
return res.status(500).json({
message: "Internal server error",
process: "Menu Creation",
});
}
};

exports.updateMenu = async (req, res) => {
try {
if (!req.user) {
return res.status(401).json({ message: 'You Have To login First' });
}
const menu = await getMenuAndAuthorize(req, req.params.menuId);
const { name, description } = req.body;
if (menu.image && req.menuImage) {
await cloud.deleteCloud(menu.image);
}
if (req.menuImage) {
menu.image = req.menuImage;
}
menu.name = name || menu.name;
menu.description = description || menu.description;
await menu.save();
return res.status(200).json({
message: 'Menu updated successfully',
menu
});
} catch (error) {
console.error("Menu Update Error:", error);
return res.status(error.status || 500).json({
message: error.message || 'Internal server error',
process: "Menu Update"
});

try {
if (!req.user) {
return res.status(401).json({ message: "You Have To login First" });
}
}
const menu = await getMenuAndAuthorize(req, req.params.menuId);
const { name, description } = req.body;
if (menu.image && req.menuImage) {
await cloud.deleteCloud(menu.image);
}
if (req.menuImage) {
menu.image = req.menuImage;
}
menu.name = name || menu.name;
menu.description = description || menu.description;
await menu.save();
return res.status(200).json({
message: "Menu updated successfully",
menu,
});
} catch (error) {
console.error("Menu Update Error:", error);
return res.status(error.status || 500).json({
message: error.message || "Internal server error",
process: "Menu Update",
});
}
};

exports.deleteMenu = async (req, res) => {
try {
if (!req.user) {
return res.status(401).json({ message: 'You Have To login First' });
}
const menu = await getMenuAndAuthorize(req, req.params.menuId);
if (menu.image) {
await cloud.deleteCloud(menu.image);
}
await menu.deleteOne();
return res.status(200).json({
message: 'Menu deleted successfully',
menu
});
} catch (error) {
console.error("Menu Deletion Error:", error);
return res.status(error.status || 500).json({
message: error.message || 'Internal server error',
process: "Menu Deletion"
});
try {
if (!req.user) {
return res.status(401).json({ message: "You Have To login First" });
}
}
const menu = await getMenuAndAuthorize(req, req.params.menuId);
if (menu.image) {
await cloud.deleteCloud(menu.image);
}
await menu.deleteOne();
return res.status(200).json({
message: "Menu deleted successfully",
menu,
});
} catch (error) {
console.error("Menu Deletion Error:", error);
return res.status(error.status || 500).json({
message: error.message || "Internal server error",
process: "Menu Deletion",
});
}
};

async function getMenuAndAuthorize(req, menuId) {
const menu = await dataAccessHelper.getMenuById(menuId);
if (!menu) {
const error = new Error('Menu not found');
error.status = 404;
throw error;
}
checkRestaurantAuthorization(req, menu);
return menu;
}
const menu = await dataAccessHelper.getMenuById(menuId);
if (!menu) {
const error = new Error("Menu not found");
error.status = 404;
throw error;
}
checkRestaurantAuthorization(req, menu);
return menu;
}
Loading