Extract element utility fns to element_util.rs
#375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes `interface.rs` file easier to navigate. Also extracted `enable_logs` to `logs.rs`. This is a refactoring that I've extracted from NSoiffer#374, where these functions are used by both the stateful and the stateless interface and I wanted to avoid any dependencies from `stateless_interface` on `interface`.
Owner
|
I think this is a good idea. Do the PR to the new "stateless" branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
interface.rsfile easier to navigate.Also extracted
enable_logstologs.rs.This is a refactoring that I've extracted from #374, where these functions are used by both the stateful and the stateless interface and I wanted to avoid any dependencies from
stateless_interfaceoninterface.