Working2 #8
Merged
Working2 #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added isCreationInProgress boolean and onFinishAction and onPageLoadAction
Added OnFinishAction and OnPageLoadAction handling and fixed a race condition when creating WebView by using the new isCreationInProgress boolean.
Added checks to prevent multiple creation attempts of WebView2 environment and controller. Removed unnecessary global meter and redraw bangs. Changed Initialized notice to debug. Added onPageLoadAction and onFinishAction.
Re-ordered creation check added check for initialization added missing reset when hr fails.
Removed redundant redraw calls after callback completion. This was causing CallJS to execute twice..
Ok, here's my attempt to solve the sync issue. Unfortunately, all my attempts to add a similar solution for window.OnInitialize and CallJS failed, both create a deadlock when implemented this way. However, this appears to solve the issue on window.OnUpdate which I think is the most important. Please build my Working2 branch and test it, you should see now both Status: Update #N on Rainmeter and on WebView are correctly synced. As well as the Measure's string value. Also add OnPageLoadAction=[!UpdateMeter *][!Redraw] on the WebView measure to correctly see the "Initialized!" message on the status string.
Removed synchronous script execution function and adjusted script execution logic in Update function.
Renamed `OnFinishAction` to `OnWebViewLoadAction` Added actions: `OnWebViewFailAction` `OnPageFirstLoadAction` `OnPageReloadAction` Added `raincontext` and `isFirstLoad` booleans. Added `UpdateRaincontext()` function.
Added raincontext handling to the Measure class, including updates to the Reload function for new actions. Implemented UpdateRaincontext function to manage the raincontext state within the WebView.
Added new actions.
Raincontext is now called AllowDualControl. The script is no longer injected when the option is disabled. Added new actions.
Added new event listeners for triggering new actions.
Adding new options and actions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.