Skip to content

Decompile dSelectCursor_c#83

Merged
RootCubed merged 7 commits intomasterfrom
d_selectcursor
Mar 2, 2026
Merged

Decompile dSelectCursor_c#83
RootCubed merged 7 commits intomasterfrom
d_selectcursor

Conversation

@TheGrop
Copy link
Collaborator

@TheGrop TheGrop commented Nov 1, 2025

No description provided.

@decomp-dev
Copy link

decomp-dev bot commented Nov 1, 2025

Report for SMNP01 (a24e665 - c237727)

📈 Matched code: 3.38% (+0.04%, +2420 bytes)
📈 Linked code: 3.39% (+0.04%, +2420 bytes)
📈 Matched data: 1.07% (+0.01%, +312 bytes)
📈 Linked data: 1.94% (+0.02%, +376 bytes)

✅ 19 new matches
Unit Item Bytes Before After
dol/bases/d_SelectCursor.cpp dSelectCursor_c::PosSet(int) +624 0.00% 100.00%
dol/bases/d_SelectCursor.cpp dSelectCursor_c::SetPane(const nw4r::lyt::Pane*, int, bool) +432 0.00% 100.00%
dol/bases/d_SelectCursor.cpp dSelectCursor_c::create() +372 0.00% 100.00%
dol/bases/d_SelectCursor.cpp .data +304 0.00% 100.00%
dol/bases/d_SelectCursor.cpp dSelectCursor_c::execute() +152 0.00% 100.00%
dol/bases/d_SelectCursor.cpp dSelectCursor_c::~dSelectCursor_c() +136 0.00% 100.00%
dol/bases/d_SelectCursor.cpp dSelectCursor_c::doDelete() +124 0.00% 100.00%
dol/bases/d_SelectCursor.cpp dSelectCursor_c::dSelectCursor_c() +112 0.00% 100.00%
dol/bases/d_SelectCursor.cpp dSelectCursor_c::draw() +108 0.00% 100.00%
dol/bases/d_SelectCursor.cpp dSelectCursor_c::Cancel(int) +108 0.00% 100.00%
dol/bases/d_SelectCursor.cpp dSelectCursor_c::Layout_c::~Layout_c() +88 0.00% 100.00%
dol/bases/d_SelectCursor.cpp dSelectCursor_c::Layout_c::Layout_c() +68 0.00% 100.00%
dol/bases/d_SelectCursor.cpp dSelectCursor_c_classInit() +48 0.00% 100.00%
dol/bases/d_SelectCursor.cpp dSelectCursor_c::SetAlpha(const nw4r::lyt::Pane*, int) +48 0.00% 100.00%
dol/bases/d_SelectCursor.cpp .sdata2 +8 0.00% 100.00%
runtime/global_destructor_chain.c __register_global_object -4 100.00% 100.00%
runtime/global_destructor_chain.c __register_global_object -4 100.00% 100.00%
runtime/global_destructor_chain.c __destroy_global_chain -12 100.00% 100.00%
runtime/global_destructor_chain.c __destroy_global_chain -12 100.00% 100.00%
🥀 2 broken matches
Unit Item Bytes Before After
runtime/global_destructor_chain.c .dtors -4 100.00% 0.00%
runtime/global_destructor_chain.c .dtors -4 100.00% 0.00%
📈 5 improvements in unmatched items
Unit Item Bytes Before After
dol/bases/d_SelectCursor.cpp .sdata +44 0.00% 92.13%
runtime/global_destructor_chain.c .sbss +5 0.00% 66.67%
runtime/global_destructor_chain.c .sbss +5 0.00% 66.67%
dol/bases/d_SelectCursor.cpp .sbss +5 0.00% 66.67%
dol/bases/d_SelectCursor.cpp .sbss2 +5 0.00% 66.67%
📉 2 regressions in unmatched items
Unit Item Bytes Before After
runtime/global_destructor_chain.c .bss -5 66.67% 0.00%
runtime/global_destructor_chain.c .bss -5 66.67% 0.00%

@CLF78 CLF78 requested a review from RootCubed March 1, 2026 23:15
user and others added 7 commits March 2, 2026 10:51
For some reason, the built main.dol doesn't have the same hash though...
Apparently the destructor needs to be explicit, otherwise the function
ordering is wrong. Also aligning the slices.
These `dSelectCursor_c` symbols are no longer needed.
@RootCubed RootCubed merged commit d2510d1 into master Mar 2, 2026
6 checks passed
@RootCubed RootCubed deleted the d_selectcursor branch March 2, 2026 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants