Skip to content

Conversation

@brtietz
Copy link
Collaborator

@brtietz brtietz commented Dec 12, 2025

Pull Request Template

Description

Change ssc vartable limits to allow analysis periods of up to 100 years.

Fixes # NREL/SAM#2140

The SAM GUI has several seconds of "not responding" when attempting to shorten a long analysis period, but this also occurs on the released version (say changing 50 to 45) so I haven't attempted to address it here.

Corresponding branches and PRs:

Develop of wex, lk, sam-private

SAM PR NREL/SAM#2139 resolves some related callback issues that make this easier to test, but these are technically independent.

Unit Test Impact:

Open to suggestions on unit test impact

Checklist

  • requires help revision and I added that label
  • adds, removes, modifies, or deletes variables in existing compute modules
  • adds a new compute module
  • changes defaults
  • I've tagged this PR to a milestone

@coveralls
Copy link

coveralls commented Dec 12, 2025

Pull Request Test Coverage Report for Build 20176253872

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.005%) to 57.732%

Files with Coverage Reduction New Missed Lines %
ssc/shared/lib_battery_dispatch_automatic_btm.cpp 1 90.84%
ssc/shared/lib_geothermal.cpp 5 65.99%
Totals Coverage Status
Change from base Build 20080783006: -0.005%
Covered Lines: 69206
Relevant Lines: 119875

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants