Various Bug Fixes #481
Merged
Various Bug Fixes #481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzalkind
changed the title
| DISCON_dict['VS_RtPwr'] = turbine.rated_power | ||
| DISCON_dict['VS_RtTq'] = turbine.rated_torque | ||
| DISCON_dict['VS_RefSpd'] = controller.vs_refspd | ||
| DISCON_dict['VS_RefSpd'] = controller.vs_refspd * (1 - controller.controller_params['ss_separation']) |
Collaborator
There was a problem hiding this comment.
I can't find any reference to 'ss_separation' in the code base.
Collaborator
Author
There was a problem hiding this comment.
This is pretty much it, to aid in a few cases where it helps to separate the set points. There's a default value (0) provided in the toolbox_schema.yaml.
Collaborator
There was a problem hiding this comment.
Is the toolbox_schema.yaml updated in some other branch? I can't find any mention of ss_separation in the schema in the main branch on my end.
Collaborator
Author
There was a problem hiding this comment.
It's being added in this PR: rosco/toolbox/inputs/toolbox_schema.yaml
dzalkind
commented
Nov 25, 2025
abhineet-gupta
approved these changes
Nov 25, 2025
Collaborator
Author
|
v210_3_WTCBench_Reporting.html Testbench results show little change with new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Purpose
Increased instances of filters/integrators: In some cases on HPC, when running a lot of FAST.Farm runs, we have seen numerical issues in the filters. These issues are not easily reproducible, so this is one simple attempt to fix a potential memory overrun if too many instances are being used simultaneously.
Tower resonances avoidance bug with gearbox ratios > 1.
Adding tuning input to separate set points of torque and pitch controllers.
Organization of some tuning scripts so the inputs and outputs are clear.
Type of change
What types of change is it?
Select the appropriate type(s) that describe this PR
TODO Items General:
TODO Items API Change:
Github issues addressed, if one exists
Examples/Testing, if applicable