Skip to content

Conversation

@atpham88
Copy link
Collaborator

Please check if the PR fulfills these requirements

  • CHANGELOG.md is updated
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

(Bug fix, feature, docs update, ...)

What is the current behavior?

(You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change?

(What changes might users need to make in their application due to this PR?)

Other information:

@atpham88 atpham88 requested a review from adfarth December 12, 2024 00:15
Copy link
Collaborator

@adfarth adfarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good! Usually we don't update the version # in the changelog until the master < develop, PR, but that doesn't really matter much. Now, we can either use this branch for testing with the web tool prior to merging into develop, or can merge and then test with the develop branch

@atpham88 atpham88 closed this Jan 27, 2025
@atpham88 atpham88 deleted the bess_duration_limit_2 branch January 28, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants