Critical load custom meter for resilience calculations #2140
Conversation
| # Create PV/CritLoad meters | ||
| if pv_key_vars.empty? && gen_key_vars.empty? | ||
| # Avoid OpenStudio warnings if nothing to decrement | ||
| Model.add_meter_custom( | ||
| model, | ||
| name: MeterCustomElectricityPV, | ||
| name: MeterCustomElectricityCriticalLoad, |
There was a problem hiding this comment.
It seems like the critical load meter is similar to the total/net meters, in that it's the facility meter minus some other things. So maybe I am not immediately seeing the nuance here, but can't you revert all of this new logic and simply change
{ MeterCustomElectricityTotal => total_key_vars,
MeterCustomElectricityNet => net_key_vars }.each do |meter_name, key_vars|
to
{ MeterCustomElectricityTotal => total_key_vars,
MeterCustomElectricityNet => net_key_vars,
MeterCustomElectricityCriticalLoad => pv_key_vars + gen_key_vars }.each do |meter_name, key_vars|
?
ReportSimulationOutput/measure.rb
Outdated
| crit_load = get_report_meter_data_timeseries([Outputs::MeterCustomElectricityCriticalLoad.upcase], UnitConversions.convert(1.0, 'J', 'kWh'), 0, resilience_frequency) | ||
| crit_load = crit_load.zip(batt_loss).map { |x, y| x + y } |
There was a problem hiding this comment.
It's nice to see all the meters removed. But I can't help to wonder if the battery losses should be incorporated in the critical load meter, rather than doing timeseries addition here?
There was a problem hiding this comment.
Hm, aren't battery losses already on Electricity:Facility? Maybe we're already adding battery losses twice, and there is a bug?
There was a problem hiding this comment.
Which I think would mean 0ae7bdb should be reverted.
There was a problem hiding this comment.
That is the conclusion I came to. See 35585cc.
joseph-robertson
changed the base branch from
master
to
battery-unit-mults-fix
Pull Request Description
Create a critical load custom meter (Electricity:Facility plus PV) to use for resilience calculations. This replaces requesting/using multiple meters (Electricity:Facility, ElectricityProduced:Facility, ElectricStorage:ElectricityProduced) for resilience calculations.
Checklist
Not all may apply:
EPvalidator.sch) has been updatedopenstudio tasks.rb update_hpxmls)HPXMLtoOpenStudio/tests/test*.rband/orworkflow/tests/test*.rb)openstudio tasks.rb update_measureshas been run