Skip to content

Conversation

@jmaguire1
Copy link
Collaborator

@jmaguire1 jmaguire1 commented Oct 4, 2023

Pull Request Description

Add an EMS program for calculating unmet water heating loads. Focus is on unmet showers, but we can also calculate this for each end use if we wanted to. Addresses #1170.

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (via tasks.rb)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests and/or workflow/tests/hpxml_translator_test.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@jmaguire1 jmaguire1 changed the title Add unmet loads EMS program Add unmet water heater loads EMS program Oct 13, 2023
@shorowit shorowit mentioned this pull request Oct 17, 2023
14 tasks
@jmaguire1
Copy link
Collaborator Author

Right now, this method calculates:

  • Unmet shower energy (mcpdelta T when T_delivered < 105 F)
  • Unmet shower time
  • Total shower time

Unmet shower energy I feel is the most complete metric, since it accounts for how far off from the desired temperature you are. However, no one really has a sense for if say 2 kWh of unmet showers is too many, so this way you can calculate the % of shower time where loads are unmet.

We could also add metrics related to ALL hot water usage, or all fixtures. We'd want to account for the different desired delivered temperature for appliances, but it wouldn't be hard to add metrics like Unmet Energy for all fixtures.

@jmaguire1 jmaguire1 mentioned this pull request Nov 1, 2023
7 tasks
Copy link
Contributor

@shorowit shorowit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments while I think of it. Addressing these comments will make it easier to pull in the master branch.

@jmaguire1
Copy link
Collaborator Author

@shorowit: I just did a major refactor of this, no more duplicate code. Thanks for the suggestions. It'd be good to know if you think this is a decent way to organize things at a minimum if/when you have a chance to take a look, we're looking to use this with the 120 V HPWH relatively soon.

@shorowit shorowit added the enhancement New feature or request label Jan 13, 2024
…o unmet_wh_loads

# Conflicts:
#	BuildResidentialScheduleFile/measure.xml
#	HPXMLtoOpenStudio/measure.xml
#	ReportSimulationOutput/measure.xml
@shorowit shorowit changed the base branch from master to schedule_file_interpolation December 13, 2024 22:07
…/OpenStudio-HPXML into unmet_wh_loads

# Conflicts:
#	HPXMLtoOpenStudio/measure.xml
#	workflow/tests/base_results/results_simulations_misc.csv
@shorowit
Copy link
Contributor

Note: I pulled #1896 into here and changed the base branch.

Base automatically changed from schedule_file_interpolation to master December 20, 2024 01:15
rajeee and others added 5 commits December 31, 2024 11:06
…o unmet_wh_loads

# Conflicts:
#	BuildResidentialScheduleFile/measure.xml
#	HPXMLtoOpenStudio/measure.xml
#	tasks.rb
#	workflow/tests/base_results/results_simulations_misc.csv
@shorowit shorowit marked this pull request as draft January 10, 2025 02:27
@shorowit shorowit moved this from In progress to Blocker/On Hold in OpenStudio-HPXML Apr 15, 2025
@shorowit shorowit modified the milestones: 1.10.0, 1.11.0 May 27, 2025
@shorowit shorowit moved this from Blocker/On Hold to In progress in OpenStudio-HPXML Jun 10, 2025
@shorowit shorowit moved this from In progress to Blocker/On Hold in OpenStudio-HPXML Nov 18, 2025
@shorowit shorowit modified the milestones: 1.11.0, 1.12.0 Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request priority low

Projects

Status: Blocker/On Hold

Development

Successfully merging this pull request may close these issues.

5 participants