Skip to content

Conversation

@shorowit
Copy link
Contributor

@shorowit shorowit commented May 9, 2022

Pull Request Description

Closes #1068.

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (via tasks.rb)
  • Unit tests have been added/updated (e.g., HPXMLtoOpenStudio/tests)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • Checked the code coverage report on CI
  • No unexpected changes to simulation results of sample files

@shorowit shorowit self-assigned this May 9, 2022
@shorowit
Copy link
Contributor Author

shorowit commented May 11, 2022

The only major remaining TODO is to expose the boiler supply temperature as an optional input. There is an existing SupplyTemperature element we can use. We could use defaults based on the hydronic distribution type (e.g., 180F in general, 160F for radiant ceiling, 120F for radiant floor). However there are a few complications:

  • What defaults do we use if a condensing boiler? Perhaps 150F in general, but what about radiant ceiling/floor?
  • How does the supply temperature relate to the higher setpoint for a boiler with outdoor reset control? BEopt allowed both to be independently set, but the only option BEopt shipped with outdoor reset uses the same value for both. Does it make sense to allow independent values? Or should the supply temperature not be an input if there is outdoor reset control?
  • The SupplyTemperature element is not available for fan coils, because we call them AirDistribution (so they can be ducted) and not HydronicDistribution. 😬 This might require creating a FanCoil HVACDistribution type in HPXML.

@shorowit shorowit added the enhancement New feature or request label May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Additional boiler capabilities

2 participants