Conversation
Collaborator
targos
commented
Aug 4, 2025
targos
commented
- fix: jquery-migrate 1.4.1 deprecations
- wip: update jQuery to v3
the dummy_module module does not exist anymore
Change color picker in favor of spectrum everywhere fixes canvas_matrix, pie_chart, leaflet, dendrogram, loading_plot and spectra_displayer
Remove jquery dependency jquery.threedubmedia
…tion The problem is problably related to jquery changing their promise implementation to be spec compliant. To reproduce: - Instantiate code editor - Instantiate code executor Results (most of the time) in a crash, or a code executor component which does not have a label on its button.
Collaborator
|
I went through all the modules and testcases, so I'm done here. See #1169 (comment) |
targos
commented
Jan 23, 2026
targos
commented
Jan 23, 2026
targos
commented
Jan 23, 2026
targos
commented
Jan 23, 2026
Collaborator
Author
|
I had a look at the changes and apart from the new comments LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.