Makes it easier to install and run, less problems. Also utilizes discord.py's command module instead of on_message#35
Open
patttterson wants to merge 11 commits intoNPCat:mainfrom
Open
Makes it easier to install and run, less problems. Also utilizes discord.py's command module instead of on_message#35patttterson wants to merge 11 commits intoNPCat:mainfrom
patttterson wants to merge 11 commits intoNPCat:mainfrom
Conversation
Updated it to use discord.py v2.1.0, also changed the command to use the commands module instead of on_message
Remove this file in favor of the README.md file instead
Make it easier to install the necessary packages
Added more instructions that I missed
Puts the frames into the frames directory, instead of just spitting them out
Creates frames directory to store the frames in
TYPO!!! YEAHHH
Author
|
Also, @NPCat , if you see this, consider taking a look at the other PRs. They have other important things that I missed here. |
|
@bot.event Dosen't seem to work? |
Author
|
Sorry, just fixed this. honestly this repository is probably completely dead so i dont really care anymore it was a stupid mistake lmaoo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Updated bad apple discord player.py to use discord.py's built-in command module instead of on_message. (See this.)
Deleted Info to run.txt and replaced it with README.md, which provides better instructions
Created requirements.txt, which makes it easier to install the required packages
Updated video to frames.py by making it put frames into a frames folder instead of spitting it out into the main directory
Side note: this PR took like an hour of work, but it will probably save the two people that want to try this for themselves a heck more time.