Roll forward to building on unity2019

.github/workflows/buildAndOptionalRelease.yml

@@ -58,25 +58,25 @@ jobs:
       - name: Setup Unity and Linux Module
         uses: seinsinnes/setup-unity@v1.1.0
         with:
-          unity-version: 2018.4.36f1
-          unity-modules: "linux"
+          unity-version: 2019.4.41f1
+          unity-modules: "linux-mono"
           install-path: "C:/Program Files"
       - name: Setup Unity Mac Module
         uses: seinsinnes/setup-unity@v1.1.0
         with:
-          unity-version: 2018.4.36f1
+          unity-version: 2019.4.41f1
           unity-modules: "mac-mono"
           install-path: "C:/Program Files"
       - name: Setup Unity Android Module
         uses: seinsinnes/setup-unity@v1.1.0
         with:
-          unity-version: 2018.4.36f1
+          unity-version: 2019.4.41f1
           unity-modules: "android"
           install-path: "C:/Program Files"
       - name: Setup Unity IOS Module
         uses: seinsinnes/setup-unity@v1.1.0
         with:
-          unity-version: 2018.4.36f1
+          unity-version: 2019.4.41f1
           unity-modules: "ios"
           install-path: "C:/Program Files"
       #Activate requires unity account creds for unity license checkout.
@@ -88,7 +88,7 @@ jobs:
           unity-authenticator-key: ${{ secrets.UNITY_AUTHENTICATOR_KEY }}
       #Move unity to where the build script expects it to be installed.
       - name: Move unity to expected location
-        run: Rename-Item "C:/Program Files/2018.4.36f1" Unity
+        run: Rename-Item "C:/Program Files/2019.4.41f1" Unity
 
       #Remove all pre-installed android sdk build tool versions except 28.0.3
       #Get-ChildItem -Path "C:/Android/android-sdk/build-tools" -Exclude 28.0.3,29.0.2 | Remove-Item -Recurse -Force

build.bat

@@ -103,7 +103,7 @@ copy %LOCALAPPDATA%\Unity\Editor\Editor.log .\build\Editor_valkyrie-windows.log
 Unity -batchmode -quit -projectPath "%~dp0unity" -buildTarget OSXUniversal -buildOSXUniversalPlayer ..\build\macos\Valkyrie.app
 copy %LOCALAPPDATA%\Unity\Editor\Editor.log .\build\Editor_valkyrie-macos.log
 
-Unity -batchmode -quit -projectPath "%~dp0unity" -buildLinuxUniversalPlayer ..\build\linux\valkyrie
+Unity -batchmode -quit -projectPath "%~dp0unity" -buildLinux64Player ..\build\linux\valkyrie
 copy %LOCALAPPDATA%\Unity\Editor\Editor.log .\build\Editor_valkyrie-linux.log
 
 Unity -batchmode -quit -projectPath "%~dp0unity" -executeMethod PerformBuild.CommandLineBuildAndroid +buildlocation "%~dp0build\android\Valkyrie-android.apk"

unity/Assets/Plugins/Android/Firebase/res/values/crashlytics_build_id.xml

@@ -1 +1 @@
-<?xml version="1.0" encoding="utf-8"?><resources><string name="com.crashlytics.android.build_id" translatable="false">4bd5dbe3-1d48-499d-bb02-f0171fde34d5</string></resources>
+<?xml version="1.0" encoding="utf-8"?><resources><string name="com.crashlytics.android.build_id" translatable="false">a0673586-e5df-494b-8385-d324cf6aa4dd</string></resources>

unity/Assets/Plugins/Android/Firebase/res/values/crashlytics_unity_version.xml

@@ -1 +1 @@
-<?xml version="1.0" encoding="utf-8"?><resources><string name="com.google.firebase.crashlytics.unity_version" translatable="false">2018.4.20f1</string></resources>
+<?xml version="1.0" encoding="utf-8"?><resources><string name="com.google.firebase.crashlytics.unity_version" translatable="false">2019.4.41f1</string></resources>

unity/Assets/Plugins/System.Buffers.xml

@@ -1,38 +1,38 @@
-<?xml version="1.0" encoding="utf-8"?><doc>
-  <assembly>
-    <name>System.Buffers</name>
-  </assembly>
-  <members>
-    <member name="T:System.Buffers.ArrayPool`1">
-      <summary>Provides a resource pool that enables reusing instances of type <see cref="T[]"></see>.</summary>
-      <typeparam name="T">The type of the objects that are in the resource pool.</typeparam>
-    </member>
-    <member name="M:System.Buffers.ArrayPool`1.#ctor">
-      <summary>Initializes a new instance of the <see cref="T:System.Buffers.ArrayPool`1"></see> class.</summary>
-    </member>
-    <member name="M:System.Buffers.ArrayPool`1.Create">
-      <summary>Creates a new instance of the <see cref="T:System.Buffers.ArrayPool`1"></see> class.</summary>
-      <returns>A new instance of the <see cref="System.Buffers.ArrayPool`1"></see> class.</returns>
-    </member>
-    <member name="M:System.Buffers.ArrayPool`1.Create(System.Int32,System.Int32)">
-      <summary>Creates a new instance of the <see cref="T:System.Buffers.ArrayPool`1"></see> class using the specifed configuration.</summary>
-      <param name="maxArrayLength">The maximum length of an array instance that may be stored in the pool.</param>
-      <param name="maxArraysPerBucket">The maximum number of array instances that may be stored in each bucket in the pool. The pool groups arrays of similar lengths into buckets for faster access.</param>
-      <returns>A new instance of the <see cref="System.Buffers.ArrayPool`1"></see> class with the specified configuration.</returns>
-    </member>
-    <member name="M:System.Buffers.ArrayPool`1.Rent(System.Int32)">
-      <summary>Retrieves a buffer that is at least the requested length.</summary>
-      <param name="minimumLength">The minimum length of the array.</param>
-      <returns>An array of type <see cref="T[]"></see> that is at least <paramref name="minimumLength">minimumLength</paramref> in length.</returns>
-    </member>
-    <member name="M:System.Buffers.ArrayPool`1.Return(`0[],System.Boolean)">
-      <summary>Returns an array to the pool that was previously obtained using the <see cref="M:System.Buffers.ArrayPool`1.Rent(System.Int32)"></see> method on the same <see cref="T:System.Buffers.ArrayPool`1"></see> instance.</summary>
-      <param name="array">A buffer to return to the pool that was previously obtained using the <see cref="M:System.Buffers.ArrayPool`1.Rent(System.Int32)"></see> method.</param>
-      <param name="clearArray">Indicates whether the contents of the buffer should be cleared before reuse. If <paramref name="clearArray">clearArray</paramref> is set to true, and if the pool will store the buffer to enable subsequent reuse, the <see cref="M:System.Buffers.ArrayPool`1.Return(`0[],System.Boolean)"></see> method will clear the <paramref name="array">array</paramref> of its contents so that a subsequent caller using the <see cref="M:System.Buffers.ArrayPool`1.Rent(System.Int32)"></see> method will not see the content of the previous caller. If <paramref name="clearArray">clearArray</paramref> is set to false or if the pool will release the buffer, the array&amp;#39;s contents are left unchanged.</param>
-    </member>
-    <member name="P:System.Buffers.ArrayPool`1.Shared">
-      <summary>Gets a shared <see cref="T:System.Buffers.ArrayPool`1"></see> instance.</summary>
-      <returns>A shared <see cref="System.Buffers.ArrayPool`1"></see> instance.</returns>
-    </member>
-  </members>
+<?xml version="1.0" encoding="utf-8"?><doc>
+  <assembly>
+    <name>System.Buffers</name>
+  </assembly>
+  <members>
+    <member name="T:System.Buffers.ArrayPool`1">
+      <summary>Provides a resource pool that enables reusing instances of type <see cref="T[]"></see>.</summary>
+      <typeparam name="T">The type of the objects that are in the resource pool.</typeparam>
+    </member>
+    <member name="M:System.Buffers.ArrayPool`1.#ctor">
+      <summary>Initializes a new instance of the <see cref="T:System.Buffers.ArrayPool`1"></see> class.</summary>
+    </member>
+    <member name="M:System.Buffers.ArrayPool`1.Create">
+      <summary>Creates a new instance of the <see cref="T:System.Buffers.ArrayPool`1"></see> class.</summary>
+      <returns>A new instance of the <see cref="System.Buffers.ArrayPool`1"></see> class.</returns>
+    </member>
+    <member name="M:System.Buffers.ArrayPool`1.Create(System.Int32,System.Int32)">
+      <summary>Creates a new instance of the <see cref="T:System.Buffers.ArrayPool`1"></see> class using the specifed configuration.</summary>
+      <param name="maxArrayLength">The maximum length of an array instance that may be stored in the pool.</param>
+      <param name="maxArraysPerBucket">The maximum number of array instances that may be stored in each bucket in the pool. The pool groups arrays of similar lengths into buckets for faster access.</param>
+      <returns>A new instance of the <see cref="System.Buffers.ArrayPool`1"></see> class with the specified configuration.</returns>
+    </member>
+    <member name="M:System.Buffers.ArrayPool`1.Rent(System.Int32)">
+      <summary>Retrieves a buffer that is at least the requested length.</summary>
+      <param name="minimumLength">The minimum length of the array.</param>
+      <returns>An array of type <see cref="T[]"></see> that is at least <paramref name="minimumLength">minimumLength</paramref> in length.</returns>
+    </member>
+    <member name="M:System.Buffers.ArrayPool`1.Return(`0[],System.Boolean)">
+      <summary>Returns an array to the pool that was previously obtained using the <see cref="M:System.Buffers.ArrayPool`1.Rent(System.Int32)"></see> method on the same <see cref="T:System.Buffers.ArrayPool`1"></see> instance.</summary>
+      <param name="array">A buffer to return to the pool that was previously obtained using the <see cref="M:System.Buffers.ArrayPool`1.Rent(System.Int32)"></see> method.</param>
+      <param name="clearArray">Indicates whether the contents of the buffer should be cleared before reuse. If <paramref name="clearArray">clearArray</paramref> is set to true, and if the pool will store the buffer to enable subsequent reuse, the <see cref="M:System.Buffers.ArrayPool`1.Return(`0[],System.Boolean)"></see> method will clear the <paramref name="array">array</paramref> of its contents so that a subsequent caller using the <see cref="M:System.Buffers.ArrayPool`1.Rent(System.Int32)"></see> method will not see the content of the previous caller. If <paramref name="clearArray">clearArray</paramref> is set to false or if the pool will release the buffer, the array&amp;#39;s contents are left unchanged.</param>
+    </member>
+    <member name="P:System.Buffers.ArrayPool`1.Shared">
+      <summary>Gets a shared <see cref="T:System.Buffers.ArrayPool`1"></see> instance.</summary>
+      <returns>A shared <see cref="System.Buffers.ArrayPool`1"></see> instance.</returns>
+    </member>
+  </members>
 </doc>