Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| void LibretroDroid::enableRewind(size_t maxBufferSizeBytes, unsigned int captureIntervalFrames) { | ||
| std::lock_guard<std::mutex> lock(rewindMutex); | ||
| rewindMaxBufferSizeBytes = maxBufferSizeBytes; | ||
| rewindCaptureInterval = std::max(1u, captureIntervalFrames); | ||
| rewindStates.clear(); |
There was a problem hiding this comment.
The implementations for enableRewind, disableRewind, rewind, and hasRewindStates are added here and the JNI layer now calls those methods, but libretrodroid.h was only updated with setRewinding/isRewinding. Because the header lacks declarations for these four methods, any translation unit including it (including this file) will fail to compile with errors such as “class LibretroDroid has no member named enableRewind”. Add the corresponding member declarations to the class definition so the build succeeds.
Useful? React with 👍 / 👎.
1 participant
Summary
Testing
./gradlew :libretrodroid:assembleDebug(fails: Unsupported class file major version 65 when compiling settings.gradle in this environment)Codex Task