Create pyproject.toml for deployment improvements#728
Create pyproject.toml for deployment improvements#728robertbartel merged 1 commit intoNOAA-OWP:masterfrom
Conversation
robertbartel
left a comment
There was a problem hiding this comment.
Thanks @ZacharyWills, this looks really good. I did have one thing I was worried about regarding Python version support that we probably should adjust unless moving to 3.12 is strictly required for this.
| version = "0.1.0" | ||
| description = "Add your description here" | ||
| readme = "README.md" | ||
| requires-python = ">=3.12" |
There was a problem hiding this comment.
So this is the only thing that give me pause. The previous project standard was to maintain compatibility with currently supported Python versions. I think we could bend that rule and remove 3.9, given how close it is to EOL, but 3.10 and 3.11 still each have a decent amount of time left.
We could discuss changing the project standard too, but I suspect unless something in this compels us to move to >= 3.12, it's simpler just to make a minor adjustment in this PR.
| requires-python = ">=3.12" | |
| requires-python = ">=3.10" |
|
I haven't tested on anything else but I'll give 3.10 and 3.11 a try. Is there a preferred version? I think I can shoehorn the packages against the python version. |
|
Given that the project is on hold until mid-26 at the very least, it's probably safe to set 3.11 as the minimum. If you were to be fairly practical/pessimistic/pragmatic, 3.12 may be fair enough. This thing isn't going to be deployable or usable or really show-off-able until at least '27 considering that it can no longer be run within OWP environments without major rearchitecting. |
|
I don't mind moving the whole project to 3.12. There are just other places that would indicate earlier versions are supported, so this would be adding another minor inconsistency. But Chris makes a good point, so as long as cleaning up that inconsistency doesn't get overlooked (i.e., it gets tracked with an issue), moving to 3.12 is probably the better long-term decision. |
[Short description explaining the high-level reason for the pull request]
Additions
-pyproject.toml
Created from the requirements.txt using
uv