Skip to content

Create pyproject.toml for deployment improvements#728

Merged
robertbartel merged 1 commit intoNOAA-OWP:masterfrom
ZacharyWills:patch-1
Jul 3, 2025
Merged

Create pyproject.toml for deployment improvements#728
robertbartel merged 1 commit intoNOAA-OWP:masterfrom
ZacharyWills:patch-1

Conversation

@ZacharyWills
Copy link
Contributor

[Short description explaining the high-level reason for the pull request]

Additions

-pyproject.toml

Created from the requirements.txt using uv

@robertbartel robertbartel self-requested a review July 2, 2025 20:24
Copy link
Contributor

@robertbartel robertbartel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ZacharyWills, this looks really good. I did have one thing I was worried about regarding Python version support that we probably should adjust unless moving to 3.12 is strictly required for this.

version = "0.1.0"
description = "Add your description here"
readme = "README.md"
requires-python = ">=3.12"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is the only thing that give me pause. The previous project standard was to maintain compatibility with currently supported Python versions. I think we could bend that rule and remove 3.9, given how close it is to EOL, but 3.10 and 3.11 still each have a decent amount of time left.

We could discuss changing the project standard too, but I suspect unless something in this compels us to move to >= 3.12, it's simpler just to make a minor adjustment in this PR.

Suggested change
requires-python = ">=3.12"
requires-python = ">=3.10"

@ZacharyWills
Copy link
Contributor Author

I haven't tested on anything else but I'll give 3.10 and 3.11 a try. Is there a preferred version? I think I can shoehorn the packages against the python version.

@christophertubbs
Copy link
Contributor

Given that the project is on hold until mid-26 at the very least, it's probably safe to set 3.11 as the minimum.

If you were to be fairly practical/pessimistic/pragmatic, 3.12 may be fair enough. This thing isn't going to be deployable or usable or really show-off-able until at least '27 considering that it can no longer be run within OWP environments without major rearchitecting.

@robertbartel
Copy link
Contributor

I don't mind moving the whole project to 3.12. There are just other places that would indicate earlier versions are supported, so this would be adding another minor inconsistency. But Chris makes a good point, so as long as cleaning up that inconsistency doesn't get overlooked (i.e., it gets tracked with an issue), moving to 3.12 is probably the better long-term decision.

@robertbartel robertbartel merged commit cf7d9fd into NOAA-OWP:master Jul 3, 2025
1 of 9 checks passed
@ZacharyWills ZacharyWills deleted the patch-1 branch July 3, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants