-
Notifications
You must be signed in to change notification settings - Fork 14
Added time log for each step and removed Bfloat16cast #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
aerorahul
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
One could introduce timing stats in rollout.chunked_predictions as well as converter.save_grib2 to further get info on computation and IO respectively through the model integration.
RussellManser-NCO
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The additional time logging looks good, but I have concerns about the change to float casting if this is intended for the current production code.
Requested changes were made. Thank you.
|
I will run a test for this on WCOSS this afternoon. |
|
The print statements are not being written to output while
|
could also add |
|
If you don't want to make code changes, add |
|
I can switch to use @RussellManser-NCO Please let me know which one you prefer. |
|
|
Logging was not unbuffered, unfortunately, even with a modified shebang. I tried |
|
OK. Thanks for testing. |
This PR made two changes to
run_graphcast.py: