Skip to content

Conversation

@RussellManser-NCO
Copy link

This PR includes the last changes that SPA team made to

  • oper/gen_aigfs_ics.py
  • oper/gen_aigefs_ics.py

to operationalize the scripts. These changes are a band-aid fix that will need a coordinated fix in the next release. A PR such as #54 would likely resolve these issues. Some key areas we will need to improve on include:

  • oper/gen_aigefs_ics.py
    • Remove boto initialization (caused failures during testing) and calls to download data from s3 buckets
    • Output netCDF file is still has mlgefs prefix, which is consistent with exaigefs_prep.sh
  • Both scripts

Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't so bad.
v1.1 will hopefully make the S3 optional and will eliminate the need to comment it out.

@LinlinCui-NOAA
Copy link
Collaborator

This isn't so bad. v1.1 will hopefully make the S3 optional and will eliminate the need to comment it out.

@aerorahul Do we know when we need to have v1.1 ready?

@aerorahul aerorahul merged commit 0ce7e95 into NOAA-EMC:production/mlglobal.v1 Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants