Copy forecast files to COM and alert them as they are created#48
Closed
RussellManser-NCO wants to merge 1 commit intoNOAA-EMC:production/mlglobal.v1from
Closed
Copy forecast files to COM and alert them as they are created#48RussellManser-NCO wants to merge 1 commit intoNOAA-EMC:production/mlglobal.v1from
RussellManser-NCO wants to merge 1 commit intoNOAA-EMC:production/mlglobal.v1from
Conversation
RussellManser-NCO
requested review from
CarlosMDiaz-NCO,
LinlinCui-NOAA,
aerorahul and
junwang-noaa
aerorahul
reviewed
Sep 16, 2025
Comment on lines
+171
to
+191
| if COMOUT is not None: | ||
| for outfile in [outfile_sfc, outfile_pres]: | ||
| proc = run_subproc([f"{CPOUT}", f"{outfile_pres}", f"{COMOUT}"]) | ||
| proc = run_subproc([f"{CPOUT}", f"{outfile_pres}.idx", f"{COMOUT}"]) | ||
| if SENDDBN is not None: | ||
| proc = run_subproc( | ||
| [f"{DBNROOT}/bin/dbn_alert", | ||
| "MODEL", | ||
| f"{prefix.upper()}_GB2", | ||
| f"{job}", | ||
| f"{COMOUT}/{os.path.basename(outfile)}" | ||
| ] | ||
| ) | ||
| proc = run_subproc( | ||
| [f"{DBNROOT}/bin/dbn_alert", | ||
| "MODEL", | ||
| f"{prefix.upper()}_GB2_IDX", | ||
| f"{job}", | ||
| f"{COMOUT}/{os.path.basename(outfile)}.idx" | ||
| ] | ||
| ) |
Contributor
There was a problem hiding this comment.
A couple items:
mlglobaldoes not need to know about the COM or DBN or prefix, does it? These are handled in the applicationsAIGFSandAIGEFS.run_subprocmeans that one has to come out of the python interpretor, and jump into a subshell -- this should be avoided.
We are going to remove the idx file generation from the forecast integration, which creates the grib2 file using a converter object. The forecast_manager would be used for several other purposes:
- generate the idx file
- copy to COM from DATA
- add triggers for post-processing for the forecast hour
Author
|
See #53 for the newest solution. |
aerorahul
added a commit
that referenced
this pull request
Sep 26, 2025
This PR calls `set_event.sh` to trigger post jobs for aigfs (see NOAA-EMC/aigfs#4). Post jobs in in NOAA-EMC/aigfs#4 create grib2 .idx files and copy fiels to COM. This PR replaces #48. --------- Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of creating a forecast manager job, here is a proposal for copying/alerting forecast files as they are created.
Wrong branch, my apologies. I will fix that tomorrow.