Skip to content

CHARM matching datasets. #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
giacomomagni wants to merge 5 commits into
base: main
Choose a base branch
from
Open

CHARM matching datasets. #76

giacomomagni wants to merge 5 commits into from

Conversation

@giacomomagni
Copy link
Contributor

@giacomomagni giacomomagni commented Feb 8, 2023

This PR is for the implementation of CHARM matching datasets with A=20.

@Radonirinaunimi Radonirinaunimi mentioned this pull request Feb 14, 2023
Closed
@giacomomagni
Copy link
Contributor Author

giacomomagni commented Jul 13, 2023

Shall we merge this @Radonirinaunimi ?

@Radonirinaunimi
Copy link
Member

Radonirinaunimi commented Aug 10, 2023

Shall we merge this @Radonirinaunimi ?

Ah, sorry I missed this comment earlier.

This I am not fully certain given that the results in the paper were produced with main (as we decided), and at least for full reproducibility that should be the reference (although the results are compatible). Maybe this could become the default in the next major release (if there will be), in the meantime we can just make sure that it is up to date w.r.t. main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@giacomomagni @Radonirinaunimi