Skip to content

Conversation

@achiefa
Copy link
Contributor

@achiefa achiefa commented Dec 3, 2024

Re-implementation of the ATLAS_WJ_8TEV in the new commondata format.

$(x, Q^2)$ map and data-theory comparison

Legacy implementation: [default], [sys_10]
New implementation: [default]

@achiefa achiefa marked this pull request as draft December 3, 2024 11:15
@achiefa achiefa self-assigned this Dec 3, 2024
@achiefa
Copy link
Contributor Author

achiefa commented Dec 4, 2024

I have implemented the default variant for this dataset. See the description of the PR above for the $(x,Q^2)$ map and the data-theory comparison. The chi2's are unchanged between the two implementations.

RE the t0 matrices, they are the same between the new implementation and the legacy variant 😬
Screenshot 2024-12-04 at 09 16 43

There is one thing that is still missing though. In the legacy implementaion, there is a sys_10 variant which accounts for two additional systematic uncertainties dubbed SCALEVAR. @enocera, @scarlehoff , do you know how to reconstruct these two additional sources?

@scarlehoff
Copy link
Member

scarlehoff commented Dec 4, 2024

RE the t0 matrices, they are the same between the new implementation and the legacy variant 😬

Hooray!

There is one thing that is still missing though. In the legacy implementaion, there is a sys_10 variant which accounts for two additional systematic uncertainties dubbed SCALEVAR. @enocera, @scarlehoff , do you know how to reconstruct these two additional sources?

These are 3pt scale variations because we don't have NNLO corrections for this data.
Tbh, I would say these are obsolete in the new implementation since if we want to add theoretical uncertainties we should do it through a theory covmat, do you agree @enocera ?

Edit: actually, given that the legacy and the default agree 100%, I would say we can merge this as it is (I'll have a look at the rest of the implementation later). If we really want to use the _10 variant, we can do it with the ported one.

@achiefa
Copy link
Contributor Author

achiefa commented Dec 4, 2024

@scarlehoff gotcha. Let's wait for the tests to finish then.

@achiefa achiefa marked this pull request as ready for review December 4, 2024 10:16
@enocera
Copy link
Contributor

enocera commented Dec 4, 2024

@achiefa Please forget about the sys_10 variant. This is indeed obsolete.

@scarlehoff
Copy link
Member

I'll wait for #2226 to be merged and then I'll merge this.

@scarlehoff scarlehoff added the Done PRs that are done but waiting on something else to merge/approve label Dec 4, 2024
@RoyStegeman RoyStegeman force-pushed the new_ATLAS_WCHARM_7TEV_WM-YL branch from 0663bc0 to c27a8a2 Compare December 4, 2024 15:26
@scarlehoff scarlehoff merged commit e8a8275 into master Dec 5, 2024
6 checks passed
@scarlehoff scarlehoff deleted the new_ATLAS_WCHARM_7TEV_WM-YL branch December 5, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ATLAS_DY_DATA data toolchain Done PRs that are done but waiting on something else to merge/approve

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants