-
Notifications
You must be signed in to change notification settings - Fork 19
Made nullContextWidget scrollable #1759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (60%) is below the target coverage (70%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #1759 +/- ##
=======================================
Coverage 60% 60%
=======================================
Files 2 2
Lines 81 81
=======================================
Hits 48 48
Misses 33 33 🚀 New features to boost your workflow:
|
pedroafmonteiro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Just a few considerations:
- On my end, when there are no restaurants, the page scrolls a bit too much. This shouldn't happen. Consider using the same implementation as we have on the Lectures/Exams page (
schedule_page.dart->nullContentWidget). - Also, while we're messing with the restaurant page, could you change how the nullContentWidget looks so it is more similar to the other ones? (with an illustration, title and description)? We're using this website to get illustrations: https://undraw.co/
If you need any help, don't hesitate on asking! Thanks again for your work!
-Fixed overscrolling on the onNullContentWidget. -Added illustration, title and descripiton to the onNullContentWidget.
… bug/restaurant-loading

Closes #1741
When an empty list was provided to the DefaultConsumer builder, he uses the nullContentWidget, which that it can't be pulled down, making the widget tree not scrollable. Therefore, it was impossible to refresh the page.
Review checklist
View Changes
Performance