Skip to content

Conversation

@Blueg00d
Copy link

@Blueg00d Blueg00d commented Dec 6, 2025

Closes #1741

When an empty list was provided to the DefaultConsumer builder, he uses the nullContentWidget, which that it can't be pulled down, making the widget tree not scrollable. Therefore, it was impossible to refresh the page.

Review checklist

  • Terms and conditions reflect the changes

View Changes

  • Description has screenshots of the UI changes.
  • Tested both in light and dark mode.
  • New text is both in portuguese (PT) and english (EN).
  • Works in different text zoom levels.
  • Works in different screen sizes.

Performance

  • No helper functions to return widgets are added. New widgets are created instead.
  • Used ListView.builder for Long Lists.
  • Controllers (TextEditingController, ...) are beeing disposed of in dispose() method.

@Blueg00d Blueg00d added the bug Something isn't working label Dec 6, 2025
@Blueg00d Blueg00d changed the title Added a Scrollable to nullContextWidget Made nullContextWidget scrollable Dec 6, 2025
@codecov
Copy link

codecov bot commented Dec 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60%. Comparing base (df5f88d) to head (4fe086b).
⚠️ Report is 1 commits behind head on develop.

❌ Your project check has failed because the head coverage (60%) is below the target coverage (70%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #1759   +/-   ##
=======================================
  Coverage       60%     60%           
=======================================
  Files            2       2           
  Lines           81      81           
=======================================
  Hits            48      48           
  Misses          33      33           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pedroafmonteiro pedroafmonteiro removed the bug Something isn't working label Dec 9, 2025
Copy link
Member

@pedroafmonteiro pedroafmonteiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Just a few considerations:

  • On my end, when there are no restaurants, the page scrolls a bit too much. This shouldn't happen. Consider using the same implementation as we have on the Lectures/Exams page (schedule_page.dart -> nullContentWidget).
  • Also, while we're messing with the restaurant page, could you change how the nullContentWidget looks so it is more similar to the other ones? (with an illustration, title and description)? We're using this website to get illustrations: https://undraw.co/

If you need any help, don't hesitate on asking! Thanks again for your work!

Blueg00d and others added 4 commits December 10, 2025 14:38
-Fixed overscrolling on the onNullContentWidget.
-Added illustration, title and descripiton to the onNullContentWidget.
@Blueg00d
Copy link
Author

New nullContentWidget for the restaurant page (Portuguese Version):
nullContentWidgetRestaurant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix reloading data on restaurants page when no data is available

3 participants