-
Notifications
You must be signed in to change notification settings - Fork 19
fix: clear cache properly on logout #1736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (60%) is below the target coverage (70%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #1736 +/- ##
=======================================
Coverage 60% 60%
=======================================
Files 2 2
Lines 81 81
=======================================
Hits 48 48
Misses 33 33 🚀 New features to boost your workflow:
|
pedroafmonteiro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
AugustoVSoares
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I'm testing the database is not being cleared properly (CourseUnit, Profile, Meal, Course are still saved after I logout). The function call Database().clear() is already ran inside the NavigationService.logoutAndPopHistory() function (it then runs unawaited(cleanupStoredData(context)) which should supposedly clear the database).
Remember to checkout the README.md in packages/uni_app/ for instructions on how to check the database to test properly!
|
Fixes:
|
AugustoVSoares
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry i forgot to send my review a while ago 😅 .
All the user sensitive data is being cleared on logout (nice 👍 ). However, I've noticed the Meal table is still not being cleared. Please check that, and let me know! (PS: Message me on slack so I don't forget to re-review this 😵 .)
Closes #1717
Clears user data base cache on logout
Review checklist
View Changes
Performance