Skip to content

Conversation

@BalloonWinter53
Copy link
Contributor

@BalloonWinter53 BalloonWinter53 commented Nov 13, 2025

Closes #1708

Shows the real-time location of the user on the map.
ℹ️ The package flutter_map_location_marker was added, as reccomended on the flutter_map website.

image

Demo (apologise for the lag - video was made on the emulator):
user_location.webm

⚠️ The feature must be tested on iOS (and, if needed, Web/MacOS/Windows/Linux) before merging.

Review checklist

  • Terms and conditions reflect the changes

View Changes

  • Description has screenshots of the UI changes.
  • Tested both in light and dark mode.
  • New text is both in portuguese (PT) and english (EN).
  • Works in different text zoom levels.
  • Works in different screen sizes.

Performance

  • No helper functions to return widgets are added. New widgets are created instead.
  • Used ListView.builder for Long Lists.
  • Controllers (TextEditingController, ...) are beeing disposed of in dispose() method.

@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60%. Comparing base (df5f88d) to head (70f996d).
⚠️ Report is 1 commits behind head on develop.

❌ Your project check has failed because the head coverage (60%) is below the target coverage (70%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #1726   +/-   ##
=======================================
  Coverage       60%     60%           
=======================================
  Files            2       2           
  Lines           81      81           
=======================================
  Hits            48      48           
  Misses          33      33           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@pedroafmonteiro pedroafmonteiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Works as expected, but consider these changes:

  • disable de proximity circle around the main location dot.
  • change the location dot color and the gyroscope color to uni red.

Apart from that, one member with an iOS device will take on this PR to fix the permissions on those devices. Thanks!

@BalloonWinter53 BalloonWinter53 changed the title Real-time location on the map feat: Real-time location on the map Nov 23, 2025
@BalloonWinter53
Copy link
Contributor Author

BalloonWinter53 commented Nov 23, 2025

Nice work! Works as expected, but consider these changes:

  • disable de proximity circle around the main location dot.
  • change the location dot color and the gyroscope color to uni red.

Apart from that, one member with an iOS device will take on this PR to fix the permissions on those devices. Thanks!

The requested changes have been made! Here is the result!

image

@pedroafmonteiro pedroafmonteiro self-requested a review November 28, 2025 10:06
also added some automatic changes to other ios files
@simaopsbarbosa
Copy link
Contributor

i added the necessary permissions for ios and everything seems to be working well, i'll test everything better at feup tomorrow 🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show user's current position on the map

4 participants