-
Notifications
You must be signed in to change notification settings - Fork 19
fix: no exams in mobility #1402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #1402 +/- ##
=======================================
- Coverage 12% 12% -0%
=======================================
Files 266 266
Lines 7218 7240 +22
=======================================
Hits 806 806
- Misses 6412 6434 +22 🚀 New features to boost your workflow:
|
|
I can't test this because I don't have a mobility account. |
I think the issue is more complicated than this. Did you check the student account I leave at #uni-reports? |
Nop, I'll check it out now |
|
The solution I propose: |
|
Closed due to inactivity. However, we must see this in the future again. |
|
To be honest, it did fix half the problem (course units). The other problem was exams. |
|
Could you explain what was the problem with the course units please? |
|
International students are enrolled in a "Mobilidade" course in SIGARRA. In that course, they have different course units from different courses from FEUP. However, "Mobilidade" is not a course that exists in SIGARRA normally, it's a special course and it's ID is null. Because of that, the fetcher throws an exception when parsing that course and, because of that, no course units are fetched from SIGARRA. |
This PR makes it so uni doesn't try to fetch exams for students with the mobility course or other courses with a null id.
Review checklist
whatsnew/whatsnew-pt-PTchangelog.mdwith the change