Skip to content

Conversation

@tomaspalma
Copy link
Member

@tomaspalma tomaspalma commented Dec 16, 2025

In order to fully test this, first delete data from the following tables:

DELETE FROM slot;
DELETE FROM class;
DELETE FROM slot_class;
DELETE FROM professor;
DELETE FROM slot_professor;

@tomaspalma tomaspalma force-pushed the refactor/slots-without-scrapper branch from a255914 to 5eeee8d Compare December 16, 2025 12:05
@tomaspalma tomaspalma force-pushed the refactor/slots-without-scrapper branch from ea6272a to fb462c6 Compare December 21, 2025 13:40
@tomaspalma tomaspalma marked this pull request as ready for review December 21, 2025 13:40
@tomaspalma tomaspalma requested a review from a team December 27, 2025 12:13
course_unit_id = int(entry.get('ocorrencia_id'))
start_time = float(entry.get('hora_inicio', 0)) / 3600.0
duration = float(entry.get('aula_duracao', 0))
location = entry.get('sala_sigla')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

location not used rn

Professor.objects.filter(id__in=professor_ids).delete()

@staticmethod
def parse_classes_from_response_new_api(response_data: list):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this logic I believe that if let's say a class changes rooms you will have both slots and not only the most recent one ( one example is T class of SGI that changed from B003 to B005)

@jose-carlos-sousa jose-carlos-sousa self-requested a review December 28, 2025 18:01
Copy link
Contributor

@jose-carlos-sousa jose-carlos-sousa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mariana2103 mariana2103 merged commit ebd358d into develop Jan 3, 2026
@mariana2103 mariana2103 deleted the refactor/slots-without-scrapper branch January 3, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants