-
Notifications
You must be signed in to change notification settings - Fork 1
refactor: slots without scrapper #253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a255914 to
5eeee8d
Compare
ea6272a to
fb462c6
Compare
| course_unit_id = int(entry.get('ocorrencia_id')) | ||
| start_time = float(entry.get('hora_inicio', 0)) / 3600.0 | ||
| duration = float(entry.get('aula_duracao', 0)) | ||
| location = entry.get('sala_sigla') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
location not used rn
| Professor.objects.filter(id__in=professor_ids).delete() | ||
|
|
||
| @staticmethod | ||
| def parse_classes_from_response_new_api(response_data: list): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this logic I believe that if let's say a class changes rooms you will have both slots and not only the most recent one ( one example is T class of SGI that changed from B003 to B005)
jose-carlos-sousa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In order to fully test this, first delete data from the following tables: