add support for AP460C #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds support for the AP460C access point model by updating the device model detection logic to recognize "460" as a valid model identifier.
Key Changes
- Added "460" to the switch case statement for models that require version parameter and use the AP230 password generation algorithm
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| password := "" | ||
| switch (*strSerial)[1:4] { | ||
| case "230", "305", "150", "630": | ||
| case "230", "305", "150", "630", "460": |
There was a problem hiding this comment.
The README.md file should be updated to reflect the new AP460 support. Currently, line 5 of README.md lists supported models as "AP130, AP150, AP230 & AP630" but does not include AP460. Consider updating the README to document this new functionality for users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.