Add endpoints for Upload/download samples metadata #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Oct 29, 2025
added 2 commits
October 29, 2025 16:06
EricSDavis
requested changes
Oct 30, 2025
Contributor
EricSDavis
left a comment
EricSDavis
left a comment
There was a problem hiding this comment.
- ✅ Download functionality works well.
- ❌ Re-uploading the same samplesheet to a project results in a 500 integrity error for samples. This could be problematic if a user wants to make partial edits to a samplesheet and re-upload it.
- 📝 Update
add_sample_to_project()to check for existing samples/sample attributes and make edits, rather than attempting to create a new sample which triggers an error.
- 📝 Update
- ℹ️ Uploading a samplesheet takes a long time. Not sure if there is a more efficient way than calling put/post requests to opensearch with each sample addition - maybe doing this as a batch?
- 🙏 Request addition of an endpoint to delete/unlink sample/samplesheet? Users otherwise have no way to remove samples linked to a project.
Contributor
Author
|
Contributor
Author
|
The upload functionality is to reset the sample metadata for all samples in the project. |
added 2 commits
October 30, 2025 18:39
Contributor
Author
|
When a samplesheet is uploaded, we can scan the bucket to ensure fastq file are present for the sample. If they are not, the sample can be highlighted in red. |
Contributor
Author
|
Also, the user should be able to re-scan the bucket to auto-populate the samplesheet, then they can download the auto-created samplesheet to populate with metadata and re-upload. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add GET "/{project_id}/samples/download" and POST "/{project_id}/samples/upload" endpoints