Skip to content

Enable db connection pooling #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
golharam merged 3 commits into from
Jan 26, 2026
Merged

Enable db connection pooling #124

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3222299
Enable db connection pooling
golharam Jan 24, 2026
e6b784e
need to adjust create_engine for sqlite
golharam Jan 24, 2026
7f6ca4a
need to adjust create_engine for sqlite
golharam Jan 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions core/db.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,23 @@
from sqlmodel import create_engine, Session
from core.config import get_settings

# Connect to db
# Set echo=True to see SQL statements in logs
engine = create_engine(str(get_settings().SQLALCHEMY_DATABASE_URI), echo=False)
# Get database URI
database_uri = str(get_settings().SQLALCHEMY_DATABASE_URI)

# Configure engine with connection pool settings for non-SQLite databases
if database_uri.startswith('sqlite'):
# SQLite: Use simple configuration (no pool parameters)
engine = create_engine(database_uri, echo=False)
else:
# PostgreSQL/MySQL: Use connection pool with keep-alive settings
engine = create_engine(
database_uri,
echo=False,
pool_pre_ping=True, # Test connections before using them
pool_recycle=3600, # Recycle connections after 1 hour
pool_size=5, # Number of connections in pool
max_overflow=10 # Max additional connections during spikes
)


# Yield session
Expand Down