Enable db connection pooling #124
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To keep the database connection alive when your APIServer is idle, you need to configure SQLAlchemy's connection pool parameters in
core/db.py. The current configuration creates an engine without pool management settings, which causes stale connections.Recommended Solution
Update
create_engine()with these parameters:Key Parameters Explained
pool_pre_ping=True(Most Important)pool_recycle=3600wait_timeoutsettingwait_timeoutis 28800 seconds (8 hours)idle_in_transaction_session_timeoutvariespool_size=5max_overflow=10Database-Specific Considerations
For PostgreSQL:
pool_recycleshould be less than server'sidle_in_transaction_session_timeoutFor MySQL:
pool_recycleshould be less thanwait_timeout(typically 28800)For SQLite:
Testing the Fix
After implementing these changes, you can verify the solution:
The
pool_pre_ping=Trueparameter is the most critical setting and will solve most idle connection timeout issues with minimal configuration changes.