Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR deprecates the Reservoir API integration by replacing the queryReservoir function with one that throws a meaningful error. The change addresses the issue that Reservoir.tools has been decommissioned and is no longer accessible, which previously resulted in unclear "failed to fetch" errors.
Changes:
- Modified
queryReservoirto throw an explanatory error instead of making API calls - Removed Reservoir-based collection fetching from the vault transformation pipeline
- Simplified
collectionSlugderivation to use only asset symbols
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/utils/src/web2/queryReservoir.ts | Replaced implementation with error-throwing stub to indicate Reservoir deprecation |
| packages/core/src/vaults/fetchVaults/transformVault.ts | Removed collection parameter and simplified collectionSlug to use only asset symbol |
| packages/core/src/vaults/fetchVaults/fetchVaults.ts | Removed collection fetching logic that depended on Reservoir API |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
reservoir.tools has been decomissioned and is no longer accessible as certain parts of nftx.js are built around reservoir (specifically for asset and collection data), they will now fail currently you will just get a "failed to fetch error" with no real explanation this commit throws a meaningful error instead it also removes the reliance on reservoir in the fetchVaults method - we don't want the entire process to fail because we're unable to fetch some optional field data whether or not we look to reimplement all of the methods that will be failing is not yet decided, the following methods are directly affected: - fetchAssets - streamAssets - fetchAssetsFromReservoir - fetchCollection - fetchUserAssets
jackmellis
force-pushed
the
fix/deprecate-reservoir
branch
from
2f7d5a7 to
0e61bfb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reservoir.tools has been decomissioned and is no longer accessible as certain parts of nftx.js are built around reservoir (specifically for asset and collection data), they will now fail currently you will just get a "failed to fetch error" with no real explanation this commit throws a meaningful error instead
it also removes the reliance on reservoir in the fetchVaults method - we don't want the entire process to fail because we're unable to fetch some optional field data whether or not we look to reimplement all of the methods that will be failing is not yet decided, the following methods are directly affected: