Skip to content

[Refactor] 혜택 로직 관련 리펙토링 #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jihoo2002 merged 4 commits into from
Aug 22, 2025
Merged

[Refactor] 혜택 로직 관련 리펙토링 #56

jihoo2002 merged 4 commits into from
Aug 22, 2025

Conversation

@jihoo2002
Copy link
Contributor

@jihoo2002 jihoo2002 commented Aug 21, 2025 •
edited
Loading

📝 PR 설명

혜택 로직 관련 리펙토링 진행했습니다

🔍 관련 이슈

✅ TODO

  • 등록수단 데이터를 결제수단 타입으로 분리해 반환하도록 DiscountInfoHelper 클래스 추가

기타

리뷰어가 알아야 할 추가 사항을 작성해주세요.

@jihoo2002 jihoo2002 self-assigned this Aug 21, 2025
@jihoo2002 jihoo2002 linked an issue Aug 21, 2025 that may be closed by this pull request
[Refactor] 혜택 로직 관련 리펙토링 #55
Closed
1 task
@jihoo2002 jihoo2002 requested a review from wnd01jun August 21, 2025 12:10
wnd01jun
wnd01jun approved these changes Aug 21, 2025
View reviewed changes
Copy link
Contributor

@wnd01jun wnd01jun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good!!

@jihoo2002
Copy link
Contributor Author

jihoo2002 commented Aug 22, 2025 •
edited
Loading

instanceof가 결제수단을 제대로 변환해주지 않는 거 같아서 찾아보니 Hibernate 프록시 이슈때문에 변환이 제대로 안될수 있다고 하더라고요
그래서 instanceof에서 Hibernate.getClass()로 변경했습니다!

@jihoo2002 jihoo2002 requested a review from wnd01jun August 22, 2025 00:27
wnd01jun
wnd01jun approved these changes Aug 22, 2025
View reviewed changes
Copy link
Contributor

@wnd01jun wnd01jun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 확인했습니다! 고생하셨어요

@jihoo2002 jihoo2002 merged commit 95c51a9 into main Aug 22, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wnd01jun wnd01jun wnd01jun approved these changes

Assignees

@jihoo2002 jihoo2002

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Refactor] 혜택 로직 관련 리펙토링

3 participants

@jihoo2002 @wnd01jun