fix: handle day overflow in monthly interval increment #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The monthly interval increment function would panic when incrementing from dates like January 31st to February, because February doesn't have 31 days.
Solution
Use chrono's
checked_add_monthsmethod which automatically handles day overflow by clamping to the last valid day of the target month.Changes
Interval::increment()to usechecked_add_months(Months::new(1))Testing
All 13 unit tests pass: