Draft
Conversation
kodeebo
reviewed
Jul 8, 2019
| const { Provider } = ExperimentsContext; | ||
| const useVariant = experiments.find( | ||
| experiment => | ||
| experiment.id.localeCompare(experimentId, undefined, { |
Contributor
There was a problem hiding this comment.
Hvorfor bruke localeCompare? Og hvorfor ikke bruke isValidExperiment funksjonen fra under?
| experiments: ExperimentShape[]; | ||
| } | ||
|
|
||
| export const fetchVariantIndex = ({ |
Contributor
There was a problem hiding this comment.
Kan ikke se at denne blir brukt noe sted? Viss den blir det bør den i en util funksjon
| experimentId, | ||
| onVariantMount, | ||
| }}> | ||
| {children} |
Contributor
There was a problem hiding this comment.
Bedre API og sende inn en array med varianter i stedet for renderprops? Trenger man ikke eksponere til ndla-frontend, og man trenger ikke context for man kan bare sende props direkte inn.
Contributor
Author
There was a problem hiding this comment.
Takk for gode tilbakemeldinger. Vi ser på saken 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.