Open
Conversation
Jonas-C
force-pushed
the
feat/oxlint
branch
3 times, most recently
from
4d3c88d to
464c157
Compare
Jonas-C
force-pushed
the
feat/oxlint
branch
3 times, most recently
from
02100a5 to
db52caf
Compare
Jonas-C
force-pushed
the
feat/oxlint
branch
4 times, most recently
from
fb05be8 to
7c1813c
Compare
gunnarvelle
reviewed
Feb 17, 2026
Comment on lines
+69
to
+77
| "lsp": { | ||
| "oxlint": { | ||
| "initialization_options": { | ||
| "settings": { | ||
| "fixKind": "all", | ||
| "typeAware": true | ||
| } | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Testa å legge dette inn i zed, men usikker på om eg får det til å fungere. Får klager i licenses.ts:
Om eg kjører "yarn lint" får eg
Failed to parse oxlint configuration file.
× Failed to load config: /home/gunnar/kode/ndla/frontend-packages/oxlint.config.ts
│
│ TypeError [ERR_UNKNOWN_FILE_EXTENSION]: Unknown file extension ".ts" for /home/gunnar/kode/ndla/frontend-packages/oxlint.config.ts
│ at Object.getFileProtocolModuleFormat [as file:] (node:internal/modules/esm/get_format:219:9)
│ at defaultGetFormat (node:internal/modules/esm/get_format:245:36)
│ at defaultLoad (node:internal/modules/esm/load:120:22)
│ at async ModuleLoader.loadAndTranslate (node:internal/modules/esm/loader:580:32)
│ at async ModuleJob._link (node:internal/modules/esm/module_job:154:19)```
Contributor
Author
There was a problem hiding this comment.
Tror dette først løses av neste versjon av oxc-extensionen i zed, sier fra når den blir sluppet!
amatho
approved these changes
Feb 19, 2026
Contributor
amatho
left a comment
amatho
left a comment
There was a problem hiding this comment.
LGTM! Fikk ikke copyright lint til å funke med nvim, men den funker med CLI så går fint
packages/oxlint-config/README.md
Outdated
|
|
||
| ```lua | ||
| { | ||
| cmd = { "./node_modules/.bin/oxlint", "--lsp" }, -- Mason doesn't have an up-to-date version of xlint, so we use the locally installed one. |
Contributor
There was a problem hiding this comment.
Suggested change
| cmd = { "./node_modules/.bin/oxlint", "--lsp" }, -- Mason doesn't have an up-to-date version of xlint, so we use the locally installed one. | |
| cmd = { "./node_modules/.bin/oxlint", "--lsp" }, -- Mason doesn't have an up-to-date version of oxlint, so we use the locally installed one. |
Jonas-C
force-pushed
the
feat/oxlint
branch
9 times, most recently
from
41c3264 to
b9ae3c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Denne begynner å bli veldig klar. Jeg har slitt litt med å få code actions til å fungere i zed, men annet enn det synes jeg dette funker fint. Vi tar en liten hit til ytelse grunnet
jsPlugins, men når oxlint integrerer de siste reglene vi mangler vil dette være veldig mye raskere enn ESLint. Dette er forsåvidt raskere enn eslint allerede nå. Man merker spesielt forskjellen når man faktisk utvikler.eslint-plugin-importer avhengig av at eslint er installert. Dersom vi midlertidig går vekk fraimport/no-extraneous-dependencieskan vi droppe nesten 1500 linjer med avhengigheter. PDD mistenker jeg at det er noe feil med zed-extensionen. Jeg sliter med å få visse code actions til å funke. Funker fint i neovim.Det er også litt kluss med graphql-reglene våre i ndla-frontend og i graphql-api. Litt usikker på hvor dealbreaker det er. Kan hende at vi gjør lurt i å beholde ESLint-configen inntil videre.