refactor: specify schemas for SQLSyntaxSupport implementation#879
Open
refactor: specify schemas for SQLSyntaxSupport implementation#879
Conversation
jnatten
force-pushed
the
refactor/schema-name-for-sqlobjects
branch
3 times, most recently
from
a24a5ab to
a1c0614
Compare
jnatten
force-pushed
the
refactor/move-learningsteps-into-path-table
branch
from
6b50cc7 to
a02369a
Compare
jnatten
force-pushed
the
refactor/schema-name-for-sqlobjects
branch
2 times, most recently
from
cbdf57d to
0c0f312
Compare
This was referenced Feb 20, 2026
jnatten
force-pushed
the
refactor/move-learningsteps-into-path-table
branch
from
a02369a to
9b8e5a2
Compare
jnatten
force-pushed
the
refactor/schema-name-for-sqlobjects
branch
from
0c0f312 to
0d9f125
Compare
jnatten
force-pushed
the
refactor/move-learningsteps-into-path-table
branch
from
9b8e5a2 to
f8f4ffa
Compare
jnatten
force-pushed
the
refactor/schema-name-for-sqlobjects
branch
from
0d9f125 to
a5b9e8e
Compare
jnatten
force-pushed
the
refactor/move-learningsteps-into-path-table
branch
from
f8f4ffa to
b3a0393
Compare
jnatten
force-pushed
the
refactor/schema-name-for-sqlobjects
branch
2 times, most recently
from
eab360b to
7f50042
Compare
This patch refactors SQLSyntaxSupport objects to classes so that they can be instanciated with props specifying the schema. This is to fix a problem where a multiple schemas could define the same tablename and cause conflicts.
jnatten
force-pushed
the
refactor/move-learningsteps-into-path-table
branch
from
7ba587c to
5d87a79
Compare
jnatten
force-pushed
the
refactor/schema-name-for-sqlobjects
branch
from
7f50042 to
8887c5f
Compare
Base automatically changed from
refactor/move-learningsteps-into-path-table
to
master
February 26, 2026 09:12
amatho
reviewed
Feb 26, 2026
Contributor
amatho
left a comment
amatho
left a comment
There was a problem hiding this comment.
En liten pirkorama, men ellers LGTM
common/src/main/scala/no/ndla/common/model/domain/config/ConfigMeta.scala
Show resolved
Hide resolved
|
|
||
| object PublishedConcept extends SQLSyntaxSupport[Concept] { | ||
| override val tableName = "publishedconceptdata" | ||
| class PublishedConcept(using props: Props) extends SQLSyntaxSupport[Concept] { |
Contributor
There was a problem hiding this comment.
Bruke samme navngiving?
Suggested change
| class PublishedConcept(using props: Props) extends SQLSyntaxSupport[Concept] { | |
| class DBPublishedConcept(using props: Props) extends SQLSyntaxSupport[Concept] { |
Contributor
Author
There was a problem hiding this comment.
Ja jeg er enig i det jeg altså, i fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/NDLANO/issues/issues/4494
Denne stacker på #877 så kan ikke merges før den er merget
This is part 2 of 3 in a stack made with GitButler: