-
Notifications
You must be signed in to change notification settings - Fork 16
Changes for el9-based cmssw versions #693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: lobster-python3
Are you sure you want to change the base?
Conversation
biglib directory is added to the sandbox
adapting wrapper.sh to lobster-python3 version fixing wrapper.sh and task.py in lobster/core/data removing leftovers and improving compatibility to el9 sandboxes removing leftovers and improving compatibility to el9 sandboxes documentation improving handling of python3
1191f8f to
ca98d08
Compare
|
@anpicci Note that with this branch we are trying to move away from parrot. The images from runos should have given you cvmfs, isn't that the case? |
|
@btovar yes, it still relies on parrot |
|
@bryates , this branch is what I use for running the skimmed samples for run3 |
|
In addition to the byte-string bug, I also had to modify task.py LL71-73 to exclude this check for Without this change the lobster task will make it through set up, but crash once it attempts to do the Removing the module did not seem to cause any other issues for the task, though likely results in some missing monitoring metrics. |
|
@anpicci another thing that I needed to change was the Right now the yaml file has it pinned to |
| from lobster.core.source import TaskProvider | ||
|
|
||
| import work_queue as wq | ||
| print('\n\n\nUsing WQ version:', wq.__version__, '\n\n\n') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that we should keep any "mandatory" print statements to a minimum. I believe this would only ever get printed once when the user does a lobster process path/to/lobster_config.py, so probably not very disruptive, but maybe there should be a better way to log/convey this information to the user.
|
|
||
| # package bin, etc | ||
| subdirs = ['bin', 'cfipython', 'external', 'lib', 'python'] | ||
| subdirs = ['bin', 'cfipython', 'external', 'lib', 'python', 'biglib'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is biglib used for? We did our full Run 3 production without it.
… task.py arguments for the skimming scripts
…ery, python selection, and safer plotting (#25) * Handle empty pie data and filter infinities in plots * Prefer local siteconf for AAA and export `CMS_LOCAL_SITE` in wrapper (#24) * biglib directory is added to the sandbox * add wq print statement * do not consider vscode open ssh sessions as a danger; manipulation of task.py arguments for the skimming scripts * modifications to make lobster working both with py2- and py3-compatible CMSSWs * Export CMS_LOCAL_SITE for shipped siteconf --------- Co-authored-by: reza goldouzian <reza.goldouzian@cern.ch> Co-authored-by: Kevin Lannon <klannon@nd.edu> Co-authored-by: Yuyi Wan <ywan2@nd.edu> * removing print statements * original lobster conda environment --------- Co-authored-by: reza goldouzian <reza.goldouzian@cern.ch> Co-authored-by: Kevin Lannon <klannon@nd.edu> Co-authored-by: Yuyi Wan <ywan2@nd.edu>
I have slightly modified the scripts in order to properly handle the CMSSW sandboxes that require el9 architecture