DEV-3190: Add aliasing to allow multiple joins to same table #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulgan
reviewed
Dec 20, 2024
| ), "Please narrow your search by specifying a node subclass" | ||
| # TODO: This is the original | ||
| for e in entities: | ||
| self = self.join(*getattr(self.entity(), e).attr) |
Contributor
There was a problem hiding this comment.
This is not obvious but its creating two join statements, one for the edge and the other for the destination node. Not clear if both joins will need an alias, but pretty sure the destination node needs one.
I played with this a little bit and was able to get the existing tests to pass
this = self
for e in entities:
relation = getattr(self.entity(), e)
alias = aliased(Node.get_subclass_named(relation.target_class.__dst_class__))
this = self.join(relation.attr[0], relation.attr[1].of_type(alias))I also had to make an update to self.entity() to cater for when the join_point is an AliasedClass not an entity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.