R validators with pretty output#97
Merged
jeanetteclark merged 19 commits intodevelopfrom Mar 27, 2026
Merged
Conversation
also remove tibble dependency
Merge branch 'develop' into feature-79-validation # Conflicts: # NAMESPACE
regetz
reviewed
Mar 26, 2026
Merge branch 'develop' into feature-79-validation # Conflicts: # NAMESPACE
regetz
approved these changes
Mar 26, 2026
Collaborator
regetz
left a comment
There was a problem hiding this comment.
Ship it! As discussed, this is leaving some nice stubs for building this out more in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains 5 validation functions that mirror the
vb_uploadfamily of functions.These functions do fairly minimal checking for:
so they do not do type checking or checking for controlled lists. Overall this validation is not as complete as the python validator, and certainly not what happens in postgres, but the intention is to get some user-friendly output to users where they might need it.
Failing output looks like:
Failing output that comes from the python validator back to the R client looks like this:
Passing output looks like:
and it returns a result object, a named list with an item for each table that was passed in and whether that table passed or failed.