Skip to content

fix: Moved the dropout layer after the normalization #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PabloNA97 merged 1 commit into from
Aug 25, 2025
Merged

fix: Moved the dropout layer after the normalization #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions mlcolvar/core/nn/feedforward.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,10 @@ def __init__(
n_layers = len(layers) - 1
# -- activation
activation_list = parse_nn_options(activation, n_layers, last_layer_activation)
# -- dropout
dropout_list = parse_nn_options(dropout, n_layers, last_layer_activation)
# -- batchnorm
batchnorm_list = parse_nn_options(batchnorm, n_layers, last_layer_activation)
# -- dropout
dropout_list = parse_nn_options(dropout, n_layers, last_layer_activation)

# Create network
modules = []
Expand All @@ -93,11 +93,11 @@ def __init__(
if activ is not None:
modules.append(get_activation(activ))

if drop is not None:
modules.append(torch.nn.Dropout(p=drop))

if norm:
modules.append(torch.nn.BatchNorm1d(layers[i + 1]))

if drop is not None:
modules.append(torch.nn.Dropout(p=drop))

# store model and attributes
self.nn = torch.nn.Sequential(*modules)
Expand Down
Loading