Skip to content

chore: MCP 설정 변경#392

Merged
wannabeing merged 1 commit intodevfrom
fix/mcp-settings
Aug 12, 2025
Merged

chore: MCP 설정 변경#392
wannabeing merged 1 commit intodevfrom
fix/mcp-settings

Conversation

@wannabeing
Copy link
Copy Markdown
Member

@wannabeing wannabeing commented Aug 12, 2025

🔎 작업 내용


🛠️ 변경 사항

  • application.properties 설정 변경

📌 참고 사항

  • 기타 공유하고 싶은 정보나 참고한 문서(링크 등)가 있다면 작성해주세요.

🙏 코드 리뷰 전 확인 체크리스트

  • 불필요한 콘솔 로그, 주석 제거
  • 커밋 메시지 컨벤션 준수 (type : )
  • 기능 정상 동작 확인

Summary by CodeRabbit

  • Chores
    • MCP 클라이언트 요청 타임아웃을 45초에서 60초로 확장하여, 네트워크 지연이나 장기 실행 작업에서도 응답 실패 가능성을 낮췄습니다.
    • 클라이언트 초기화 상태 제어 플래그를 추가해 시작 시 동작 안정성을 높였습니다.
    • 일부 자동 구성을 제외하여 불필요한 컴포넌트 로딩을 줄이고, 애플리케이션 기동 일관성과 성능을 개선했습니다.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Aug 12, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

애플리케이션 설정에서 MCP 클라이언트 요청 타임아웃을 45s에서 60s로 변경하고, 초기화 상태 플래그를 추가했으며, Spring AI ToolCalling 자동구성을 제외하도록 설정을 추가했습니다.

Changes

Cohort / File(s) Change Summary
구성 프로퍼티 업데이트
cs25-service/src/main/resources/application.properties
- spring.ai.mcp.client.request-timeout: 45s → 60s
- spring.ai.mcp.client.initialized=false 추가
- spring.autoconfigure.exclude=org.springframework.ai.model.tool.autoconfigure.ToolCallingAutoConfiguration 추가

Sequence Diagram(s)

sequenceDiagram
    participant App as Application
    participant SB as Spring Boot
    participant AC as AutoConfig
    participant MCP as MCP Client

    App->>SB: 애플리케이션 시작
    SB->>AC: 자동구성 로딩
    AC--xSB: ToolCallingAutoConfiguration 제외
    SB->>MCP: MCP 클라이언트 구성 (timeout=60s, initialized=false)
    App->>MCP: 요청 처리
Loading

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • jong-0126
  • Ksr-ccb
  • HeeMang-Lee
  • crocusia
  • Kimyoonbeom

Poem

토끼 발굽 톡톡, 설정을 다듬네 🐇
타임아웃 늘리고, 초기 깃발 세웠지
자동구성 살짝 빼고 길 정리했더니
봄바람처럼 가벼운 부팅 소리~
깡총, 이제 MCP로 고고! 🚀


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0d86a8c and 8e69cdf.

📒 Files selected for processing (1)
  • cs25-service/src/main/resources/application.properties (1 hunks)
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/mcp-settings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@wannabeing wannabeing merged commit 0879420 into dev Aug 12, 2025
1 of 2 checks passed
@wannabeing wannabeing deleted the fix/mcp-settings branch August 12, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants