Skip to content

chore: MCP 설정의 배열 args의 null 예외 방지#371

Merged
wannabeing merged 1 commit intodevfrom
chore/mcp-settings
Aug 11, 2025
Merged

chore: MCP 설정의 배열 args의 null 예외 방지#371
wannabeing merged 1 commit intodevfrom
chore/mcp-settings

Conversation

@wannabeing
Copy link
Copy Markdown
Member

@wannabeing wannabeing commented Aug 11, 2025

🔎 작업 내용

  • args 설정 자체를 안했더니 null 예외 발생
  • --stdioMCP 표준 실행 플래그라서 의미상 가장 안전한 의미의 값 설정

🛠️ 변경 사항

  • 구현한 주요 로직, 클래스, 메서드 등을 bullet 형식으로 기술해주세요.
  • 예)
    • UserService.createUser() 메서드 추가
    • @Email 유효성 검증 적용

🧩 트러블 슈팅

Caused by: org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'braveSearchMcpService' defined in URL [jar:nested:/apps/app.jar/!BOOT-INF/classes/!/com/example/cs25service/domain/ai/service/BraveSearchMcpService.class]: Unsatisfied dependency expressed through constructor parameter 0: Error creating bean with name 'mcpSyncClients' defined in class path resource [org/springframework/ai/mcp/client/autoconfigure/McpClientAutoConfiguration.class]: Failed to instantiate [java.util.List]: Factory method 'mcpSyncClients' threw exception with message: Error creating bean with name 'stdioTransports' defined in class path resource [org/springframework/ai/mcp/client/autoconfigure/StdioTransportAutoConfiguration.class]: Failed to instantiate [java.util.List]: Factory method 'stdioTransports' threw exception with message: The args can not be null

🧯 해결해야 할 문제

  • 기능은 동작하지만 리팩토링이나 논의가 필요한 부분을 적어주세요.
  • 예)D
    • UserController에서 비즈니스 로직 일부 처리 → 서비스로 이전 고려 필요

📌 참고 사항

  • 기타 공유하고 싶은 정보나 참고한 문서(링크 등)가 있다면 작성해주세요.

🙏 코드 리뷰 전 확인 체크리스트

  • 불필요한 콘솔 로그, 주석 제거
  • 커밋 메시지 컨벤션 준수 (type : )
  • 기능 정상 동작 확인

Summary by CodeRabbit

  • Chores
    • Brave 통합의 STDIO 기반 통신을 활성화하는 구성 항목을 추가해 연결 설정을 명확화했습니다.
    • 기존 Brave 관련 환경값과 함께 동작하도록 정리해 배포 시 설정 오류 가능성을 낮췄습니다.
    • 로컬 및 운영 환경에서 일관된 초기화를 돕도록 구성 일치를 강화했습니다.
    • 운영 구성 관리가 간소화되어 설정 가시성과 유지보수성이 향상되었습니다.

@wannabeing wannabeing merged commit a7a7759 into dev Aug 11, 2025
1 check passed
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Aug 11, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Brave STDIO 연결을 위한 새 인자 설정 spring.ai.mcp.client.stdio.connections.brave.args[0]=--stdio 가 application.properties에 추가되었으며, 기존 Brave STDIO 관련 설정(명령, BRAVE_API_KEY)은 그대로 유지됨.

Changes

Cohort / File(s) Change summary
Configuration Update
cs25-service/src/main/resources/application.properties
Brave STDIO 클라이언트에 args[0]=--stdio 속성 추가. 기존 command 및 환경변수 설정은 변경 없음.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

토끼는 깡충, 설정 한 줄 톡!
--stdio 깃발 펄럭, 연결은 똑딱 척!
키는 그대로, 명령도 그대로,
한 줄 더해 흐름이 매끄러워요.
오늘도 로그는 잔잔, 귀는 쫑긋 행복한 밤. 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f725ffc and fa249cf.

📒 Files selected for processing (1)
  • cs25-service/src/main/resources/application.properties (1 hunks)
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/mcp-settings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[08.11]10차 배포 후 백엔드 모든 요청에 502에러 반환

4 participants