Skip to content

Conversation

@alexdunnjpl
Copy link
Contributor

🗒️ Summary

'nuf said

⚙️ Test Data and/or Report

in-progress

♻️ Related Issues

Related to NASA-PDS/deep-archive#236
Related to #717
Related to #720

Tightly-coupled to NASA-PDS/registry-sweepers#204

🤓 Reviewer Checklist

Reviewers: Please verify the following before approving this pull request.

Security & Quality

  • SonarCloud: Confirmed no new High or Critical security findings.
  • Secrets Detection: Verified that the Secrets Detection scan passed and no sensitive information (keys, tokens, PII) is exposed.
  • Code Quality: Code follows organization style guidelines and best practices for the specific language (e.g., PEP 8, Google Java Style).

Testing & Validation

  • Test Accuracy: Verified that test data is accurate, representative of real-world PDS4 scenarios, and sufficient for the logic being tested.
  • Coverage: Automated tests cover new logic and edge cases.
  • Local Verification: (If applicable) Successfully built and ran the changes in a local or staging environment.

Documentation

  • Documentation: README, Wiki, or inline documentation (Sphinx, Javadoc, Docstrings) have been updated to reflect these changes.

Maintenance

  • Issue Traceability: The PR is linked to a valid GitHub Issue or Jira Ticket.
  • Backward Compatibility: Confirmed that these changes do not break existing downstream dependencies or API contracts (or that breaking changes are clearly documented).

@alexdunnjpl alexdunnjpl requested a review from a team as a code owner January 12, 2026 22:58
@alexdunnjpl alexdunnjpl marked this pull request as draft January 12, 2026 23:05
@alexdunnjpl alexdunnjpl force-pushed the ancestry-overhaul-update branch from 716b8f3 to 9fa41f2 Compare January 12, 2026 23:09
…ified matchMembers() which leverages the new post-overhaul ancestry metadata
@alexdunnjpl alexdunnjpl force-pushed the ancestry-overhaul-update branch from 9fa41f2 to 097ea9d Compare January 12, 2026 23:11
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants