Add reclat #45
Closed
Add reclat #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dyst5422
commented
Mar 5, 2025
| const Module = this.module; | ||
| // create input pointer | ||
|
|
||
| const rectan_ptr = Module._malloc(DOUBLE_SIZE * 3); |
Author
There was a problem hiding this comment.
I think this needs to be freed below after results have been read.
Member
|
@gkjohnson Are you good with this? |
Collaborator
|
I'm not sure if I feel we need to expose every spice function via the lib interface. This function is extremely simple and to be honest porting it directly would be a lot simpler and less error prone than dealing with all of the WASM pointer and memory management. Here's the cspice reclat implementation in a Github mirror repo: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
reclatfunction and a simple test against it.