Set attribute "data-node-id" on each node#21
Set attribute "data-node-id" on each node#21Geoffrey-D wants to merge 3 commits intoN00ts:masterfrom
Conversation
|
Hello, since vue js is based on data mutation for DOM manipulation (virutal DOM), i'm not sure having an ID for manipulation is relevant. Why did you put "data-node-id" instead of a real :id ? What is your use case ? |
|
I need to open and focus nodes programatically, and as no "API" allowed such things, I had to:
I have added in this MR 2 API methods to do those things in an "API" object: I have also changed the "data-node-id" attr to "id" as it makes more sense |
|
What do you think of those 2 features? Can we merge them? |
|
Hey @N00ts could you please give a feedback on this? Thx :) |
|
Hey I had a look to your PR. I have multiple remarks.
|
This facilitate DOM manipulation :)