Conversation
zhouwfang
force-pushed
the
zhoufang/iop-116-make-t-and-allowed_delta-configurable
branch
2 times, most recently
from
d5e011c to
1cca276
Compare
| let (nodes, threshold) = build_reduced_nodes(&committee, allowed_delta, weight_divisor)?; | ||
| let (nodes, threshold) = build_reduced_nodes( | ||
| &committee, | ||
| threshold_basis_points, |
There was a problem hiding this comment.
The name confused me a bit. You call it basis points here because you're defining the threshold as some ratio with a fixed denominator, MAX_BASIS_POINTS, and then use this to compute the threshold with the actual given weights, right? if so, I'd call this something else, like TOTAL_BASIS_WEIGHT, or just document the relationship with THRESHOLD_BASIS_POINTS.
There was a problem hiding this comment.
I renamed threshold_basis_points to be threshold_in_basis_points to make it clear this is "the threshold, expressed in basis points" rather than "basis points of the threshold." I kept MAX_BASIS_POINTS rather than TOTAL_BASIS_WEIGHT, which sounds like a sum of something that could vary rather than a fixed constant.
zhouwfang
force-pushed
the
zhoufang/iop-116-make-t-and-allowed_delta-configurable
branch
from
4f79ce9 to
dfe42fc
Compare
zhouwfang
force-pushed
the
zhoufang/iop-116-make-t-and-allowed_delta-configurable
branch
from
4bd3b8a to
dfe42fc
Compare
zhouwfang
deleted the
zhoufang/iop-116-make-t-and-allowed_delta-configurable
branch
3 participants
#368