Multi domain support #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This pull request adds support for configuring multiple domains on the slipstream server, allowing it to accept DNS queries for different domain suffixes. When multiple domains are configured, the server selects the longest matching suffix for each incoming query.
Changes:
- Added repeatable
--domainflag to server CLI and environment variable support (DOMAINSandCLIENT_DOMAIN) in test scripts - Implemented longest-suffix matching algorithm in DNS decoder with comprehensive test coverage
- Added overlap detection with warnings for duplicate or overlapping domain configurations
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| scripts/interop/run_rust_rust.sh | Added support for DOMAINS and CLIENT_DOMAIN environment variables with parsing and sanitization |
| scripts/README.md | Updated documentation to mention multi-domain environment variables |
| docs/usage.md | Marked --domain as repeatable and documented longest-suffix matching behavior |
| docs/protocol.md | Added specification for multi-domain suffix matching |
| docs/dns-codec.md | Updated codec documentation to reflect multi-domain support |
| crates/slipstream-server/tests/cert_pinning_e2e.rs | Modified e2e test to exercise multi-domain functionality |
| crates/slipstream-server/src/server.rs | Added domain overlap warnings and switched to decode_query_with_domains |
| crates/slipstream-server/src/main.rs | Changed --domain argument from single String to Vec with required flag |
| crates/slipstream-dns/tests/multi_domain.rs | Added comprehensive unit tests for multi-domain matching behavior |
| crates/slipstream-dns/src/lib.rs | Exported decode_query_with_domains function |
| crates/slipstream-dns/src/dns.rs | Implemented extract_subdomain_multi with longest-suffix matching algorithm |
| .github/workflows/ci.yml | Added multi-domain test configuration to CI matrix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6.